Use LocalDefId instead of NodeId in resolve_str_path_error
#72781
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
petrochenkov
added
the
S-waiting-on-author
marmeladema
force-pushed
the
rustdoc-def-id-resolve-str-path-error
branch
from
ff59cf4 to
e9e243e
Compare
marmeladema
force-pushed
the
rustdoc-def-id-resolve-str-path-error
branch
from
e9e243e to
372ba2a
Compare
|
@bors r+ |
|
📌 Commit 372ba2a has been approved by |
bors
added
S-waiting-on-bors
RalfJung
added a commit
to RalfJung/rust
that referenced
this pull request
May 31, 2020
…str-path-error, r=petrochenkov Use `LocalDefId` instead of `NodeId` in `resolve_str_path_error` Together with rust-lang#72777 this should remove all uses of `NodeId` in `rustdoc`. cc rust-lang#50928 r? @petrochenkov
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
May 31, 2020
Rollup of 5 pull requests Successful merges: - rust-lang#72683 (from_u32_unchecked: check validity, and fix UB in Wtf8) - rust-lang#72715 (Account for trailing comma when suggesting `where` clauses) - rust-lang#72745 (generalize Borrow<[T]> for Interned<'tcx, List<T>>) - rust-lang#72749 (Update stdarch submodule to latest head) - rust-lang#72781 (Use `LocalDefId` instead of `NodeId` in `resolve_str_path_error`) Failed merges: r? @ghost
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Together with #72777 this should remove all uses of
NodeIdinrustdoc.cc #50928
r? @petrochenkov