Skip to content

Conversation

alexcrichton
Copy link
Member

Follow-up from #71716 I wasn't able to add in time.

@rust-highfive
Copy link
Contributor

r? @steveklabnik

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label May 4, 2020
@alexcrichton
Copy link
Member Author

r? @nnethercote

Copy link
Contributor

@nnethercote nnethercote left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

r=me once the nits are addressed.

Follow-up from rust-lang#71716 I wasn't able to add in time.
@alexcrichton alexcrichton force-pushed the embed-bitcode-docs branch from e531f3d to 0b35692 Compare May 4, 2020 21:47
@alexcrichton
Copy link
Member Author

@bors: r=nnethercote

@bors
Copy link
Collaborator

bors commented May 4, 2020

📌 Commit 0b35692 has been approved by nnethercote

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels May 4, 2020
bors added a commit to rust-lang-ci/rust that referenced this pull request May 5, 2020
Rollup of 4 pull requests

Successful merges:

 - rust-lang#69984 (Add Option to Force Unwind Tables)
 - rust-lang#71830 (Remove clippy from some leftover lists of "possibly failing" tools)
 - rust-lang#71894 (Suggest removing semicolon in last expression only if it's type is known)
 - rust-lang#71897 (Improve docs for embed-bitcode and linker-plugin-lto)

Failed merges:

r? @ghost
@bors bors merged commit 3efcba6 into rust-lang:master May 5, 2020
@alexcrichton alexcrichton deleted the embed-bitcode-docs branch July 23, 2020 21:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants