Skip to content

Conversation

Mark-Simulacrum
Copy link
Member

Fixes #71152

The extracted function can be used by the rest of bootstrap to detect if we've
already built an up-to-date LLVM (and so it's safe for us to either request it
or pretend it exists).
@rust-highfive
Copy link
Contributor

@Mark-Simulacrum: no appropriate reviewer found, use r? to override

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label May 2, 2020
@Mark-Simulacrum
Copy link
Member Author

cc @jonas-schievink -- maybe you'd be up to review this?

@jonas-schievink
Copy link
Contributor

Looks good!

@bors r+

@bors
Copy link
Collaborator

bors commented May 2, 2020

📌 Commit 7f645ab has been approved by jonas-schievink

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels May 2, 2020
@Mark-Simulacrum
Copy link
Member Author

@bors p=1 since it affects lots of developer's productivity

@bors
Copy link
Collaborator

bors commented May 3, 2020

⌛ Testing commit 7f645ab with merge 0a675c5...

@bors
Copy link
Collaborator

bors commented May 3, 2020

☀️ Test successful - checks-azure
Approved by: jonas-schievink
Pushing 0a675c5 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label May 3, 2020
@bors bors merged commit 0a675c5 into rust-lang:master May 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

rustc_llvm need to be rebuilt after ./x.py check
4 participants