Minor fixes to doc comments of 'VecDeque' #71219
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1. Changed descriptions of `fn get` & `fn get_mut`. Since both of these functions are returning references, and not the owned value, I thought the doc comments could be fixed to be consistent with doc comments of `fn front` & `fn front_mut`. 2. Other changes are minor fixes or additions for clarification. Thank you for taking a look :)
|
r? @dtolnay (rust_highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
JOE1994
changed the title
|
Thanks! @bors r+ rollup |
|
📌 Commit 9707bec has been approved by |
bors
added
S-waiting-on-bors
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Apr 16, 2020
Rollup of 5 pull requests Successful merges: - rust-lang#70611 (Add long error explanation for E0708 rust-lang#61137) - rust-lang#71197 (Don't use the HirId to NodeId map in MIR) - rust-lang#71211 (Update cargo) - rust-lang#71219 (Minor fixes to doc comments of 'VecDeque') - rust-lang#71221 (Dogfood or_patterns in rustdoc) Failed merges: r? @ghost
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changed descriptions of
fn get&fn get_mut.Since both of these functions are returning references, and not the owned value, I thought the doc comments could be fixed to be consistent with doc comments of
fn front&fn front_mut.Other changes are minor fixes or additions for clarification.
Thank you for taking a look :)