Deprecate {Box,Rc,Arc}::into_raw_non_null
#71168
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @kennytm (rust_highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
SimonSapin
commented
Apr 15, 2020
RalfJung
reviewed
Apr 15, 2020
RalfJung
reviewed
Apr 15, 2020
Co-Authored-By: Ralf Jung <[email protected]>
RalfJung
reviewed
Apr 15, 2020
SimonSapin
force-pushed
the
into_raw_non_null
branch
from
3e0da06 to
86a060f
Compare
RalfJung
reviewed
Apr 15, 2020
… instead of the other way around.
SimonSapin
force-pushed
the
into_raw_non_null
branch
from
86a060f to
7709d20
Compare
RalfJung
approved these changes
Apr 16, 2020
crlf0710
added
the
T-libs-api
Closed
|
@bors r+ |
|
📌 Commit 7709d20 has been approved by |
bors
added
S-waiting-on-bors
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Apr 25, 2020
Rollup of 7 pull requests Successful merges: - rust-lang#69041 (proc_macro: Stabilize `Span::resolved_at` and `Span::located_at`) - rust-lang#69813 (Implement BitOr and BitOrAssign for the NonZero integer types) - rust-lang#70712 (stabilize BTreeMap::remove_entry) - rust-lang#71168 (Deprecate `{Box,Rc,Arc}::into_raw_non_null`) - rust-lang#71544 (Replace filter_map().next() calls with find_map()) - rust-lang#71545 (Fix comment in docstring example for Error::kind) - rust-lang#71548 (Add missing Send and Sync impls for linked list Cursor and CursorMut.) Failed merges: r? @ghost
yvt
added a commit
to yvt/Stella2
that referenced
this pull request
May 4, 2020
`Box::into_raw_non_null` was recently deprecated by <rust-lang/rust#71168> and will probably be removed after some time.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Per ongoing FCP at #47336 (comment)
See also #47336 (comment)