Skip to content

resolve: Do not resolve visibilities on proc macro definitions twice #70233

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 23, 2020
Merged

resolve: Do not resolve visibilities on proc macro definitions twice #70233

merged 1 commit into from
Mar 23, 2020

Conversation

@petrochenkov
Copy link
Contributor

Fixes #68921

@rust-highfive
Copy link
Contributor

r? @ecstatic-morse

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Mar 21, 2020
@petrochenkov petrochenkov mentioned this pull request Mar 21, 2020
Closed
tesuji
tesuji reviewed Mar 22, 2020
View reviewed changes
@petrochenkov petrochenkov mentioned this pull request Mar 22, 2020
Merged
Dylan-DPC-zz pushed a commit to Dylan-DPC-zz/rust that referenced this pull request Mar 22, 2020
@Dylan-DPC
Rollup merge of rust-lang#70266 - petrochenkov:prochead, r=varkor
69c0bcd 
proc_macro_harness: Use item header spans for errors

Addresses rust-lang#70233 (comment).
@ecstatic-morse
Copy link
Contributor

@bors r+

@bors
Copy link
Collaborator

bors commented Mar 22, 2020

📌 Commit eb5db70e8676c9525df1f9d179ffdfaf858bed4d has been approved by ecstatic-morse

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 22, 2020
@petrochenkov
Copy link
Contributor Author

@bors r-
(Needs a rebase after #70266.)

@bors bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Mar 22, 2020
@petrochenkov
Copy link
Contributor Author

@bors r=ecstatic-morse

@bors
Copy link
Collaborator

bors commented Mar 23, 2020

📌 Commit c3c0a09 has been approved by ecstatic-morse

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Mar 23, 2020
@Centril Centril mentioned this pull request Mar 23, 2020
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Mar 23, 2020
@bors
Auto merge of rust-lang#70305 - Centril:rollup-zi13fz4, r=Centril
5aa8f19 
Rollup of 8 pull requests

Successful merges:

 - rust-lang#69080 (rustc_codegen_llvm: don't generate any type debuginfo for -Cdebuginfo=1.)
 - rust-lang#69940 (librustc_codegen_llvm: Replace deprecated API usage)
 - rust-lang#69942 (Increase verbosity when suggesting subtle code changes)
 - rust-lang#69968 (rustc: keep upvars tupled in {Closure,Generator}Substs.)
 - rust-lang#70123 (Ensure LLVM is in the link path for rustc tools)
 - rust-lang#70159 (Update the bundled wasi-libc with libstd)
 - rust-lang#70233 (resolve: Do not resolve visibilities on proc macro definitions twice)
 - rust-lang#70286 (Miri error type: remove UbExperimental variant)

Failed merges:

r? @ghost
@bors bors merged commit bb85308 into rust-lang:master Mar 23, 2020
@petrochenkov petrochenkov deleted the superproc branch February 22, 2025 18:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@tesuji tesuji tesuji left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@ecstatic-morse ecstatic-morse

Labels

S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

ICE with proc_macro_attribute on pub(super) function in module

5 participants

@petrochenkov @rust-highfive @ecstatic-morse @bors @tesuji