Skip to content

Conversation

Centril
Copy link
Contributor

@Centril Centril commented Mar 21, 2020

The whole point of this PR is the very last commit, in which we remove rustc as one of rustc_ast_lowering's dependencies, thereby improving ./x.py parallelism and working towards #65031.

Noteworthy:

  • From rustc::arena we move logic into arena, in particular declare_arena!. This is then used in rustc_ast_lowering so that lowering has its own separate arena.
  • Some linting code is unfortunately moved to rustc_session::lint cause its used both in rustc_lint and rustc_ast_lowering, and this is their common dependency.
  • rustc_session::CrateDisambiguator is moved into rustc_ast so that rustc::hir::map::definitions can be moved into rustc_hir, so that rustc_ast_lowering can stop referring to rustc::hir.

r? @Zoxc

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Mar 21, 2020
@Centril Centril force-pushed the unshackled-lowering branch from 74cf684 to 5746fd4 Compare March 21, 2020 04:51
@bors

This comment has been minimized.

@Centril Centril force-pushed the unshackled-lowering branch from 5746fd4 to 40cec78 Compare March 21, 2020 21:25
@Zoxc
Copy link
Contributor

Zoxc commented Mar 22, 2020

@bors try @rust-timer queue

@rust-timer
Copy link
Collaborator

Awaiting bors try build completion

@bors
Copy link
Collaborator

bors commented Mar 22, 2020

⌛ Trying commit 40cec78 with merge f60543b065b8eff6ea6ea5d5a66f80541574b97e...

@Zoxc
Copy link
Contributor

Zoxc commented Mar 22, 2020

r=me if perf is fine

@bors
Copy link
Collaborator

bors commented Mar 22, 2020

☀️ Try build successful - checks-azure
Build commit: f60543b065b8eff6ea6ea5d5a66f80541574b97e (f60543b065b8eff6ea6ea5d5a66f80541574b97e)

@rust-timer
Copy link
Collaborator

Queued f60543b065b8eff6ea6ea5d5a66f80541574b97e with parent 1902d1e, future comparison URL.

@rust-timer
Copy link
Collaborator

Finished benchmarking try commit f60543b065b8eff6ea6ea5d5a66f80541574b97e, comparison URL.

@Zoxc
Copy link
Contributor

Zoxc commented Mar 23, 2020

That's an unexpected perf result :/

@bors r+

@bors
Copy link
Collaborator

bors commented Mar 23, 2020

📌 Commit 40cec78 has been approved by Zoxc

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 23, 2020
@Centril
Copy link
Contributor Author

Centril commented Mar 23, 2020

@bors rollup=never p=1 (perf)

@bors
Copy link
Collaborator

bors commented Mar 23, 2020

⌛ Testing commit 40cec78 with merge 37c945d...

@bors
Copy link
Collaborator

bors commented Mar 23, 2020

☀️ Test successful - checks-azure
Approved by: Zoxc
Pushing 37c945d to master...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants