Skip to content

[rustdoc] Improve visibility for code blocks warnings #70005

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 19, 2020
Merged

[rustdoc] Improve visibility for code blocks warnings #70005

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d4ea327
Make ignore and compile fail signs more visible
GuillaumeGomez Mar 14, 2020
8216a32
remove compilation warning
GuillaumeGomez Mar 14, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion src/librustdoc/clean/inline.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,6 @@ use rustc_hir::Mutability;
use rustc_metadata::creader::LoadedMacro;
use rustc_mir::const_eval::is_min_const_fn;
use rustc_span::hygiene::MacroKind;
use rustc_span::symbol::sym;
use rustc_span::Span;

use crate::clean::{self, GetDefId, ToSource, TypeKind};
Expand Down
13 changes: 10 additions & 3 deletions src/librustdoc/html/static/rustdoc.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1032,7 +1032,7 @@ h3 > .collapse-toggle, h4 > .collapse-toggle {

.information {
position: absolute;
left: -20px;
left: -25px;
margin-top: 7px;
z-index: 1;
}
Expand All @@ -1047,12 +1047,13 @@ h3 > .collapse-toggle, h4 > .collapse-toggle {
width: 120px;
display: none;
text-align: center;
padding: 5px 3px;
padding: 5px 3px 3px 3px;
border-radius: 6px;
margin-left: 5px;
top: -5px;
left: 105%;
z-index: 10;
font-size: 16px;
}

.tooltip:hover .tooltiptext {
Expand All @@ -1063,14 +1064,20 @@ h3 > .collapse-toggle, h4 > .collapse-toggle {
content: " ";
position: absolute;
top: 50%;
left: 11px;
left: 16px;
margin-top: -5px;
border-width: 5px;
border-style: solid;
}

.tooltip.compile_fail, .tooltip.ignore {
font-weight: bold;
font-size: 20px;
}

.tooltip .tooltiptext {
border: 1px solid;
font-weight: normal;
}

pre.rust {
Expand Down
9 changes: 5 additions & 4 deletions src/librustdoc/html/static/themes/dark.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -254,7 +254,7 @@ a.test-arrow:hover{
}

pre.compile_fail {
border-left: 2px solid rgba(255,0,0,.6);
border-left: 2px solid rgba(255,0,0,.8);
}

pre.compile_fail:hover, .information:hover + pre.compile_fail {
Expand All @@ -270,7 +270,7 @@ pre.ignore:hover, .information:hover + pre.ignore {
}

.tooltip.compile_fail {
color: rgba(255,0,0,.6);
color: rgba(255,0,0,.8);
}

.information > .compile_fail:hover {
Expand All @@ -282,16 +282,17 @@ pre.ignore:hover, .information:hover + pre.ignore {
}

.information > .ignore:hover {
color: rgba(255,142,0,1);
color: #ff9200;
}

.search-failed a {
color: #0089ff;
}

.tooltip .tooltiptext {
background-color: black;
background-color: #000;
color: #fff;
border-color: #000;
}

.tooltip .tooltiptext::after {
Expand Down
12 changes: 6 additions & 6 deletions src/librustdoc/html/static/themes/light.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -248,43 +248,43 @@ a.test-arrow:hover{
}

pre.compile_fail {
border-left: 2px solid rgba(255,0,0,.4);
border-left: 2px solid rgba(255,0,0,.5);
}

pre.compile_fail:hover, .information:hover + pre.compile_fail {
border-left: 2px solid #f00;
}

pre.ignore {
border-left: 2px solid rgba(255,142,0,.4);
border-left: 2px solid rgba(255,142,0,.6);
}

pre.ignore:hover, .information:hover + pre.ignore {
border-left: 2px solid #ff9200;
}

.tooltip.compile_fail {
color: rgba(255,0,0,.3);
color: rgba(255,0,0,.5);
}

.information > .compile_fail:hover {
color: #f00;
}

.tooltip.ignore {
color: rgba(255,142,0,.3);
color: rgba(255,142,0,.6);
}

.information > .ignore:hover {
color: rgba(255,142,0,1);
color: #ff9200;
}

.search-failed a {
color: #0089ff;
}

.tooltip .tooltiptext {
background-color: black;
background-color: #000;
color: #fff;
}

Expand Down