- 
                Notifications
    You must be signed in to change notification settings 
- Fork 13.9k
Refactorings to method/probe.rs and CrateId #69812
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
          
     Merged
      
      
    
                
     Merged
            
            
          Conversation
  
    
      This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
      Learn more about bidirectional Unicode characters
    
  
  
    
    | (rust_highfive has picked a reviewer for you, use r? to override) | 
              
                    Marwes
  
              
              commented
              
                  
                    Mar 7, 2020 
                  
              
              
            
            
              
                    petrochenkov
  
              
              reviewed
              
                  
                    Mar 8, 2020 
                  
              
              
            
            
| @bors r+ rollup | 
| 📌 Commit 6095fa1 has been approved by  | 
| 🌲 The tree is currently closed for pull requests below priority 1000, this pull request will be tested once the tree is reopened | 
    
  Centril 
      added a commit
        to Centril/rust
      that referenced
      this pull request
    
      Mar 8, 2020 
    
    
      
  
    
      
    
  
Refactorings to method/probe.rs and CrateId A couple of refactorings done while looking into performance improvements in method resolution.
    
  bors 
      added a commit
      that referenced
      this pull request
    
      Mar 8, 2020 
    
    
      
  
    
      
    
  
Rollup of 8 pull requests Successful merges: - #69631 (remove non-sysroot sources from rust-src component) - #69646 (Miri visitor: detect primitive types based on type, not layout (also, more tests)) - #69651 (Try to ensure usize marker does not get merged) - #69668 (More documentation and simplification of BTreeMap's internals) - #69685 (unix: Don't override existing SIGSEGV/BUS handlers) - #69771 (Cleanup E0390 explanation) - #69777 (Add missing ` in doc for File::with_options()) - #69812 (Refactorings to method/probe.rs and CrateId) Failed merges: r? @ghost
    
  bors 
      added a commit
      that referenced
      this pull request
    
      Mar 8, 2020 
    
    
      
  
    
      
    
  
Rollup of 7 pull requests Successful merges: - #69631 (remove non-sysroot sources from rust-src component) - #69646 (Miri visitor: detect primitive types based on type, not layout (also, more tests)) - #69651 (Try to ensure usize marker does not get merged) - #69668 (More documentation and simplification of BTreeMap's internals) - #69771 (Cleanup E0390 explanation) - #69777 (Add missing ` in doc for File::with_options()) - #69812 (Refactorings to method/probe.rs and CrateId) Failed merges: r? @ghost
  
    Sign up for free
    to join this conversation on GitHub.
    Already have an account?
    Sign in to comment
  
      Labels
      
    S-waiting-on-bors
  Status: Waiting on bors to run and complete tests. Bors will change the label on completion. 
  Add this suggestion to a batch that can be applied as a single commit.
  This suggestion is invalid because no changes were made to the code.
  Suggestions cannot be applied while the pull request is closed.
  Suggestions cannot be applied while viewing a subset of changes.
  Only one suggestion per line can be applied in a batch.
  Add this suggestion to a batch that can be applied as a single commit.
  Applying suggestions on deleted lines is not supported.
  You must change the existing code in this line in order to create a valid suggestion.
  Outdated suggestions cannot be applied.
  This suggestion has been applied or marked resolved.
  Suggestions cannot be applied from pending reviews.
  Suggestions cannot be applied on multi-line comments.
  Suggestions cannot be applied while the pull request is queued to merge.
  Suggestion cannot be applied right now. Please check back later.
  
    
  
    
A couple of refactorings done while looking into performance improvements in method resolution.