Rename `libsyntax` to `librustc_ast` #69592

petrochenkov · 2020-02-29T19:01:16Z

This was the last rustc crate that wasn't following the rustc_* naming convention.

Follow-up to #67763.

Centril · 2020-02-29T22:27:34Z

r? @Centril @bors r+

bors · 2020-02-29T22:27:35Z

📌 Commit e08c279 has been approved by Centril

Centril · 2020-03-01T00:48:56Z

Let's bump this cause this will be massively bitrotty: @bors p=10

bors · 2020-03-01T01:37:06Z

⌛ Testing commit e08c279 with merge 2917d99...

bors · 2020-03-01T04:42:14Z

☀️ Test successful - checks-azure
Approved by: Centril
Pushing 2917d99 to master...

rust-highfive · 2020-03-01T04:43:28Z

📣 Toolstate changed by #69592!

Tested on commit 2917d99.
Direct link to PR: #69592

💔 clippy-driver on windows: test-fail → build-fail (cc @mcarton @oli-obk @Manishearth @flip1995 @yaahc @phansch @llogiq).
💔 clippy-driver on linux: test-fail → build-fail (cc @mcarton @oli-obk @Manishearth @flip1995 @yaahc @phansch @llogiq).
💔 miri on windows: test-fail → build-fail (cc @oli-obk @eddyb @RalfJung).
💔 miri on linux: test-fail → build-fail (cc @oli-obk @eddyb @RalfJung).

@mcarton

Tested on commit rust-lang/rust@2917d99. Direct link to PR: <rust-lang/rust#69592> 💔 clippy-driver on windows: test-fail → build-fail (cc @mcarton @oli-obk @Manishearth @flip1995 @yaahc @phansch @llogiq). 💔 clippy-driver on linux: test-fail → build-fail (cc @mcarton @oli-obk @Manishearth @flip1995 @yaahc @phansch @llogiq). 💔 miri on windows: test-fail → build-fail (cc @oli-obk @eddyb @RalfJung). 💔 miri on linux: test-fail → build-fail (cc @oli-obk @eddyb @RalfJung).

eddyb · 2020-03-02T07:54:37Z

src/bootstrap/dist.rs

            "src/librustc",
-            "src/libsyntax",
+            "src/librustc_ast",


I don't understand why these are included here, is this left over from when src/libproc_macro had a dependency on these two crates? If so, we've shipping a lot of pointless rustc source code for a while now.

cc @Mark-Simulacrum @dtolnay

They were added by #58269 to fix #58268

Huh, but why these crates specifically? #58268 doesn't explain why those vs the entire source distribution (which is still available.. somehow, right?)

My best guess: intellij-rust/intellij-rust#2623 (referenced by that issue) mentions compiler plugins.

I don't think the entire source distribution is otherwise available as a rustup component.

Well, this list is probably missing a couple crates in terms of plugin development and nobody brought this up, maybe it's time to remove them. I'll bring this up on the existing issue.

eddyb · 2020-03-02T07:57:26Z

@petrochenkov @Centril Do we plan to remove the redudancy of rustc_ast::ast?
Similar to how we have use rustc_hir as hir; imports for the HIR, we should be able to now also have use rustc_ast as ast; IMO.

It would also be nice to be able to write paths like ast::visit::walk_....

Fix plugin tests for latest nightly. Crate was renamed in rust-lang/rust#69592.

@eddyb

remove non-sysroot sources from rust-src component See rust-lang#69592 (comment): these were likely added in rust-lang#58269 for the sake of compiler plugins, but those are being entirely phased out, so there is no good reason to ship these sources. OTOH, @eddyb [wrote](rust-lang#58269 (comment)) > Yeah, my question is why librustc_plugin specifically? Everything else makes sense. So maybe there is some good reason to keep these? Then we should have a comment explaining that reason. Cc @eddyb @taeguk @Mark-Simulacrum

@eddyb

remove non-sysroot sources from rust-src component See rust-lang#69592 (comment): these were likely added in rust-lang#58269 for the sake of compiler plugins, but those are being entirely phased out, so there is no good reason to ship these sources. OTOH, @eddyb [wrote](rust-lang#58269 (comment)) > Yeah, my question is why librustc_plugin specifically? Everything else makes sense. So maybe there is some good reason to keep these? Then we should have a comment explaining that reason. Cc @eddyb @taeguk @Mark-Simulacrum

…crichton Fix plugin tests for latest nightly. Crate was renamed in rust-lang/rust#69592.

petrochenkov added 3 commits February 29, 2020 20:47

Move directory libsyntax -> librustc_ast

e94d3b7

Make it build again

6054a30

Rename syntax to rustc_ast in source code

e08c279

rust-highfive assigned eddyb Feb 29, 2020

rust-highfive assigned Centril and unassigned eddyb Feb 29, 2020

bors added the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label Feb 29, 2020

bors added the merged-by-bors This PR was explicitly merged by bors. label Mar 1, 2020

bors merged commit 2917d99 into rust-lang:master Mar 1, 2020

This was referenced Mar 1, 2020

Cleanup rmeta::MacroDef #66364

Merged

--show-coverage json #66472

Merged

rust-highfive mentioned this pull request Mar 1, 2020

clippy-driver no longer builds after rust-lang/rust#69592 #69601

Closed

This was referenced Mar 1, 2020

Deduplicate pretty printing of constants #67133

Merged

const limit for CTFE #67260

Merged

Prevent query cycles in the MIR inliner #68828

Merged

JohnTitor added a commit to JohnTitor/rust-clippy that referenced this pull request Mar 1, 2020

Rustup to rust-lang/rust#69592

4253aa7

eddyb reviewed Mar 2, 2020

View reviewed changes

RalfJung mentioned this pull request Mar 2, 2020

remove non-sysroot sources from rust-src component #69631

Merged

ehuss mentioned this pull request Mar 2, 2020

Fix plugin tests for latest nightly. rust-lang/cargo#7955

Merged

bors added a commit to rust-lang/cargo that referenced this pull request Mar 2, 2020

Auto merge of #7955 - ehuss:fix-plugin-syntax-rename, r=alexcrichton

cc5a5e5

Fix plugin tests for latest nightly. Crate was renamed in rust-lang/rust#69592.

calebcartwright mentioned this pull request Mar 4, 2020

panic in publish job due to libsyntax rename alexcrichton/rustc-auto-publish#17

Closed

ehuss pushed a commit to ehuss/cargo that referenced this pull request Mar 16, 2020

Auto merge of rust-lang#7955 - ehuss:fix-plugin-syntax-rename, r=alex…

0a77863

…crichton Fix plugin tests for latest nightly. Crate was renamed in rust-lang/rust#69592.

kvark mentioned this pull request May 5, 2020

No updates in the last 2 months alexcrichton/rustc-auto-publish#21

Closed

petrochenkov deleted the nosyntax branch February 22, 2025 18:33

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Rename `libsyntax` to `librustc_ast` #69592

Rename `libsyntax` to `librustc_ast` #69592

Uh oh!

petrochenkov commented Feb 29, 2020

Uh oh!

Centril commented Feb 29, 2020

Uh oh!

bors commented Feb 29, 2020

Uh oh!

Centril commented Mar 1, 2020

Uh oh!

bors commented Mar 1, 2020

Uh oh!

bors commented Mar 1, 2020

Uh oh!

rust-highfive commented Mar 1, 2020

Uh oh!

eddyb Mar 2, 2020

Uh oh!

RalfJung Mar 2, 2020

Uh oh!

eddyb Mar 2, 2020

Uh oh!

RalfJung Mar 2, 2020 •

edited

Loading

Uh oh!

eddyb Mar 2, 2020

Uh oh!

eddyb commented Mar 2, 2020

Uh oh!

Uh oh!

Rename libsyntax to librustc_ast #69592

Rename libsyntax to librustc_ast #69592

Uh oh!

Conversation

petrochenkov commented Feb 29, 2020

Uh oh!

Centril commented Feb 29, 2020

Uh oh!

bors commented Feb 29, 2020

Uh oh!

Centril commented Mar 1, 2020

Uh oh!

bors commented Mar 1, 2020

Uh oh!

bors commented Mar 1, 2020

Uh oh!

rust-highfive commented Mar 1, 2020

Uh oh!

eddyb Mar 2, 2020

Choose a reason for hiding this comment

Uh oh!

RalfJung Mar 2, 2020

Choose a reason for hiding this comment

Uh oh!

eddyb Mar 2, 2020

Choose a reason for hiding this comment

Uh oh!

RalfJung Mar 2, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

eddyb Mar 2, 2020

Choose a reason for hiding this comment

Uh oh!

eddyb commented Mar 2, 2020

Uh oh!

Uh oh!

Rename `libsyntax` to `librustc_ast` #69592

Rename `libsyntax` to `librustc_ast` #69592

RalfJung Mar 2, 2020 •

edited

Loading