Skip to content

Conversation

Blei
Copy link
Contributor

@Blei Blei commented Jun 5, 2013

Handle more characters that appear in types, most notably <>): were
missing. Also the new scheme takes care that no two different input
strings result in the same mangled string, which was not the case before.

Fixes #6921

Handle more characters that appear in types, most notably <>): were
missing. Also the new scheme takes care that no two different input
strings result in the same mangled string, which was not the case before.

Fixes #6921
@Blei
Copy link
Contributor Author

Blei commented Jun 5, 2013

Hmm, that might be a good idea. Also, I'm not really sure if we handle the last case correctly (pushing all characters that are in XID Continue). Maybe this should be replaced by a warning instead.

bors added a commit that referenced this pull request Jun 5, 2013
Handle more characters that appear in types, most notably <>): were
missing. Also the new scheme takes care that no two different input
strings result in the same mangled string, which was not the case before.

Fixes #6921
@bors bors closed this Jun 5, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants