Skip to content

Clean up E0310 explanation #69233

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 18, 2020
Merged

Clean up E0310 explanation #69233

merged 1 commit into from
Feb 18, 2020

Conversation

@GuillaumeGomez
Copy link
Member

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Feb 17, 2020
Dylan-DPC-zz
Dylan-DPC-zz suggested changes Feb 17, 2020
View reviewed changes
src/librustc_error_codes/error_codes/E0310.md Outdated
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
doesn't live long enough.
does not live long enough.

src/librustc_error_codes/error_codes/E0310.md Outdated
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
represent how long the data stored within them is guaranteed to be live. This
represent how long the data stored within them is guaranteed to live. This

@GuillaumeGomez
Copy link
Member Author

Updated!

@Dylan-DPC-zz
Copy link

@bors r+ rollup

@bors
Copy link
Collaborator

bors commented Feb 18, 2020

📌 Commit 73283f1 has been approved by Dylan-DPC

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Feb 18, 2020
Dylan-DPC-zz pushed a commit to Dylan-DPC-zz/rust that referenced this pull request Feb 18, 2020
@Dylan-DPC
Rollup merge of rust-lang#69233 - GuillaumeGomez:cleanup-e0310, r=Dyl…
210b181 
…an-DPC

Clean up E0310 explanation

r? @Dylan-DPC
@Dylan-DPC-zz Dylan-DPC-zz mentioned this pull request Feb 18, 2020
Merged
bors added a commit that referenced this pull request Feb 18, 2020
@bors
Auto merge of #69262 - Dylan-DPC:rollup-m6dt9cn, r=Dylan-DPC
e620d0f 
Rollup of 5 pull requests

Successful merges:

 - #69181 (Change const eval to just return the value )
 - #69192 (Add more regression tests)
 - #69200 (Fix printing of `Yield` terminator)
 - #69205 (Allow whitespaces in revision flags)
 - #69233 (Clean up E0310 explanation)

Failed merges:

r? @ghost
@bors bors merged commit 73283f1 into rust-lang:master Feb 18, 2020
@GuillaumeGomez GuillaumeGomez deleted the cleanup-e0310 branch August 19, 2024 12:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@Dylan-DPC-zz Dylan-DPC-zz Dylan-DPC-zz requested changes

Reviewers whose approvals may not affect merge requirements

Assignees

@Dylan-DPC-zz Dylan-DPC-zz

Labels

S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@GuillaumeGomez @Dylan-DPC-zz @bors @rust-highfive