Skip to content

Conversation

XAMPPRocky
Copy link
Contributor

@XAMPPRocky XAMPPRocky commented Feb 6, 2020

This PR was made using GitHub's UI and it seems that some the unicode for two other people's name was also changed.

@rust-highfive
Copy link
Contributor

r? @alexcrichton

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Feb 6, 2020
@Mark-Simulacrum
Copy link
Member

r? @Mark-Simulacrum

Could you verify that the Unicode name changes are not in practice changing things? It doesn't look like it in my browser but I don't have time to investigate in detail. If you want to just drop those changes that's fine with me too.

Otherwise r=me; @bors rollup=always

@Mark-Simulacrum Mark-Simulacrum added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Feb 6, 2020
@Dylan-DPC-zz
Copy link

@XAMPPRocky can you update this?

@XAMPPRocky
Copy link
Contributor Author

I'm just going to open a new PR since it's easier.

@XAMPPRocky XAMPPRocky closed this Mar 2, 2020
@XAMPPRocky XAMPPRocky deleted the XAMPPRocky-patch-1-1 branch March 2, 2020 11:04
Dylan-DPC-zz pushed a commit to Dylan-DPC-zz/rust that referenced this pull request Mar 2, 2020
Dylan-DPC-zz pushed a commit to Dylan-DPC-zz/rust that referenced this pull request Mar 3, 2020
JohnTitor added a commit to JohnTitor/rust that referenced this pull request Mar 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants