Add an early-exit to QueryNormalizer::fold_ty
#68606
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rust-highfive
added
the
S-waiting-on-review
4 tasks
This comment has been minimized.
This comment has been minimized.
|
@bors try @rust-timer queue |
|
Awaiting bors try build completion |
|
⌛ Trying commit 474d0e3 with merge 0c5d24e029a4ba74ad3647cefef127bf15ae6200... |
This comment has been minimized.
This comment has been minimized.
|
@bors rollup=never since this is a perf win, and we want to avoid masking regressions from other PRs in the rollup. |
|
Seems like we already did the perf testing @bors try- |
|
@bors r+ |
|
📌 Commit 474d0e3 has been approved by |
bors
added
S-waiting-on-bors
|
@bors p=1 |
|
☀️ Test successful - checks-azure |
bors
added a commit
that referenced
this pull request
Feb 3, 2020
Re-land "add IntoFuture trait and support for await" Testing the code from #65244 to see if the performance regressions are still there. #68606 and #68672 made perf optimizations that might interact with this change. If this lands, fixes #67982. cc @seanmonstar @jonas-schievink r? @cramertj
jonas-schievink
added
the
relnotes
jonas-schievink
added
the
relnotes-perf
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pulled out from #68524, this results in a ~60-70% reduction in compile time for the await-call-tree benchmarks. This should unblock #67982 as well.
r? @Zoxc