- 
                Notifications
    You must be signed in to change notification settings 
- Fork 13.9k
Remove mem::uninitalized from tests #67507
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
| cc @RalfJung | 
| r? @RalfJung | 
| I would personally prefer that we don't block on @RalfJung here, given that this is a relatively simple replacement operation, and they don't have much review time. I personally think you are likely knowledgeable enough to at least do a review before saying "these bits I'm not sure about" if such bits exist? If that's an incorrect impression though I'm fine with waiting (or trying to find another reviewer). | 
| Yeah I feel like I am drowning in requests for review and other requests for comments, leaving less than 0 time for my own Rust projects, which is quite the motivation killer. I need some way to reduce that incoming flood.^^ | 
10205cd    to
    28a1319      
    Compare
  
    There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
r=me with these comments below addressed :)
| r? @Centril | 
28a1319    to
    cb599cc      
    Compare
  
    | @bors r=Centril Thanks! | 
| 📌 Commit cb599cc has been approved by  | 
| 🌲 The tree is currently closed for pull requests below priority 100, this pull request will be tested once the tree is reopened | 
…tril Remove mem::uninitalized from tests This purges uses of uninitialized where possible from test cases. Some are merely moved over to the equally bad pattern of MaybeUninit::uninit().assume_init() but with an annotation that this is "the best we can do". Fixes rust-lang#67507
| The job  Click to expand the log.I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact  | 
| @bors r- ^-- | 
cb599cc    to
    3445117      
    Compare
  
    | Forgot to run tests after review nits were fixed :/ I think we should probably wait for CI here to pass and then reapprove | 
3445117    to
    80023fe      
    Compare
  
    | The job  Click to expand the log.I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact  | 
80023fe    to
    7c84a7a      
    Compare
  
    | The job  Click to expand the log.I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact  | 
| 
 I think you pasted the wrong number :P | 
b199de8    to
    85d30ec      
    Compare
  
    | The job  Click to expand the log.I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact  | 
85d30ec    to
    49c0560      
    Compare
  
    | The job  Click to expand the log.I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact  | 
This purges uses of uninitialized where possible from test cases. Some are merely moved over to the equally bad pattern of MaybeUninit::uninit().assume_init() but with an annotation that this is "the best we can do".
49c0560    to
    c205f6a      
    Compare
  
    | @bors r=Centril | 
| 📌 Commit c205f6a has been approved by  | 
| 🌲 The tree is currently closed for pull requests below priority 100, this pull request will be tested once the tree is reopened | 
…tril Remove mem::uninitalized from tests This purges uses of uninitialized where possible from test cases. Some are merely moved over to the equally bad pattern of MaybeUninit::uninit().assume_init() but with an annotation that this is "the best we can do". Fixes rust-lang#62397
Rollup of 8 pull requests Successful merges: - #67233 (Add PartialEq and Eq to Cursor) - #67466 (Require const stability attributes on intrinsics to be able to use them in constant contexts) - #67507 (Remove mem::uninitalized from tests) - #67527 (Results show too much) - #67536 (Move `{hir::lowering -> hir}::is_range_literal`) - #67538 (Improve diagnostics for invalid assignment) - #67546 (Fix ICE in mir interpretation) - #67559 (Document that calling Drop, even after it panics, is UB) Failed merges: r? @ghost
This purges uses of uninitialized where possible from test cases. Some
are merely moved over to the equally bad pattern of
MaybeUninit::uninit().assume_init() but with an annotation that this is
"the best we can do".
Fixes #62397