Use constraint span when lowering associated types #63620
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rust-highfive
added
the
S-waiting-on-review
This comment has been minimized.
This comment has been minimized.
estebank
force-pushed
the
assoc-type-span
branch
from
4c0cf88 to
a29af43
Compare
|
cc @alexreg |
estebank
force-pushed
the
assoc-type-span
branch
from
a29af43 to
e695c78
Compare
This comment has been minimized.
This comment has been minimized.
estebank
force-pushed
the
assoc-type-span
branch
from
e695c78 to
9241895
Compare
Centril
reviewed
Aug 16, 2019
src/test/ui/associated-item/associated-item-type-issue-63594.rs
Outdated
Show resolved
Hide resolved
|
cc #52662 |
|
r=me with changes ^--- |
|
Thanks @estebank! |
Centril
added
S-waiting-on-author
estebank
force-pushed
the
assoc-type-span
branch
from
9241895 to
1808e4d
Compare
|
@bors r=Centril |
|
📌 Commit 1808e4d has been approved by |
bors
added
S-waiting-on-bors
Centril
added a commit
to Centril/rust
that referenced
this pull request
Aug 19, 2019
Use constraint span when lowering associated types Fix rust-lang#63594. r? @Centril
bors
added a commit
that referenced
this pull request
Aug 19, 2019
Rollup of 5 pull requests Successful merges: - #63252 (Remove recommendation about idiomatic syntax for Arc::clone) - #63376 (use different lifetime name for object-lifetime-default elision) - #63620 (Use constraint span when lowering associated types) - #63699 (Fix suggestion from incorrect `move async` to `async move`.) - #63704 ( Fixed: error: unnecessary trailing semicolon) Failed merges: r? @ghost
9 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #63594.
r? @Centril