Skip to content

Conversation

GuillaumeGomez
Copy link
Member

Fixes #60326.

cc @rust-lang/rustdoc
r? @QuietMisdreavus

@jonas-schievink jonas-schievink added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. labels Jul 26, 2019
@GuillaumeGomez
Copy link
Member Author

r? @ollie27

@GuillaumeGomez
Copy link
Member Author

To be done: add a test with into slice like Vec to check if the slice's methods are there.

@GuillaumeGomez
Copy link
Member Author

It's a bug fix open since two weeks with no news so let's just get it in...

@bors: r=nobody rollup

@bors
Copy link
Collaborator

bors commented Aug 6, 2019

📌 Commit 4fb29f9 has been approved by nobody

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 6, 2019
@Mark-Simulacrum
Copy link
Member

@bors r-

The appropriate step here is to ping folks, not approve patches yourself. I'll try to review this later today.

@bors bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Aug 6, 2019
@Mark-Simulacrum
Copy link
Member

@bors r+

@bors
Copy link
Collaborator

bors commented Aug 6, 2019

📌 Commit 4fb29f9 has been approved by Mark-Simulacrum

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Aug 6, 2019
Centril added a commit to Centril/rust that referenced this pull request Aug 6, 2019
…r=Mark-Simulacrum

Not listed methods

Fixes rust-lang#60326.

cc @rust-lang/rustdoc
r? @QuietMisdreavus
bors added a commit that referenced this pull request Aug 6, 2019
Rollup of 6 pull requests

Successful merges:

 - #62459 (Use internal iteration in the Sum and Product impls of Result and Option)
 - #62821 (Not listed methods)
 - #62837 (Fix theme picker blur handler: always hide instead of switching)
 - #63286 (Replace error callback with Result)
 - #63296 (Deduplicate rustc_demangle in librustc_codegen_llvm)
 - #63298 (assume_init: warn about valid != safe)

Failed merges:

r? @ghost
@bors bors merged commit 4fb29f9 into rust-lang:master Aug 6, 2019
@GuillaumeGomez GuillaumeGomez deleted the not-listed-methods branch August 7, 2019 07:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[doc-gen] Vec::iter_mut is missing from the side list of the doc page
5 participants