Rollup of 4 pull requests #62467
Merged
Rollup of 4 pull requests #62467
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This avoids adding archives multiple times, which results in duplicate objects in the resulting rlib, leading to symbol collision and link failures. This could happen when crate contains multiple link attributes that all reference the same archive.
RFC 2457 declares: "A `non_ascii_idents` lint is added to the compiler. This lint is allow by default."
They always end up interned anyway
…=Manishearth `non_ascii_idents` lint (part of RFC 2457) RFC 2457 [declares](https://github.com/rust-lang/rfcs/blob/121bbeff500c3274cea22c7e0ca176274d592646/text/2457-non-ascii-idents.md): "A `non_ascii_idents` lint is added to the compiler. This lint is allow by default." (Part of rust-lang#55467.) r? @Manishearth
Support stability and deprecation checking for all macros RELNOTES: Deprecation attributes on macros now have effect. Fixes rust-lang#34079 Fixes rust-lang#49912 Unblocks rust-lang#62086 Unblocks rust-lang#61000
…laumeGomez rustdoc: set cfg(doctest) when collecting doctests Note: This PR builds on top of rust-lang#61199; only the last commit is specific to this PR. As discussed in rust-lang#61199, we want the ability to isolate items to only when rustdoc is collecting doctests, but we can't use `cfg(test)` because of libcore's `#![cfg(not(test))]`. This PR proposes a new cfg flag, `cfg(doctest)`, specific to this situation, rather than reusing an existing flag. I've isolated it behind a feature gate so that we can contain the effects to nightly only. (A stable workaround that can be used in lieu of `#[cfg(doctest)]` is `#[cfg(rustdoc)] #[doc(hidden)]`, at least once rust-lang#61351 lands.) Tracking issue: rust-lang#62210
…es, r=cramertj Check if the archive has already been added to avoid duplicates This avoids adding archives multiple times, which results in duplicate objects in the resulting rlib, leading to symbol collision and link failures. This could happen when crate contains multiple link attributes that all reference the same archive.
|
@bors r+ p=4 rollup=never |
|
📌 Commit a2500db has been approved by |
bors
added
the
S-waiting-on-bors
bors
added a commit
that referenced
this pull request
Jul 7, 2019
Rollup of 4 pull requests Successful merges: - #61883 (`non_ascii_idents` lint (part of RFC 2457)) - #62042 (Support stability and deprecation checking for all macros) - #62213 (rustdoc: set cfg(doctest) when collecting doctests) - #62286 (Check if the archive has already been added to avoid duplicates) Failed merges: r? @ghost
|
☀️ Test successful - checks-azure, checks-travis, status-appveyor |
rust-highfive
added a commit
to rust-lang-nursery/rust-toolstate
that referenced
this pull request
Jul 7, 2019
Tested on commit rust-lang/rust@9210359. Direct link to PR: <rust-lang/rust#62467> 🎉 rls on linux: test-fail → test-pass (cc @Xanewok, @rust-lang/infra).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Successful merges:
non_ascii_identslint (part of RFC 2457) #61883 (non_ascii_identslint (part of RFC 2457))Failed merges:
r? @ghost