- 
                Notifications
    
You must be signed in to change notification settings  - Fork 13.9k
 
rustdoc: remove unused derives and variants #62224
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
          
     Merged
      
      
    
                
     Merged
            
            
          Conversation
  
    
      This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
      Learn more about bidirectional Unicode characters
    
  
  
    
    | 
           Thanks! @bors: r+  | 
    
| 
           📌 Commit e991abd has been approved by   | 
    
    
  Centril 
      added a commit
        to Centril/rust
      that referenced
      this pull request
    
      Jun 29, 2019 
    
    
      
  
    
      
    
  
…omez rustdoc: remove unused derives and variants Though many structs in rustdoc derive `RustcEncodable` and `RustcDecodable`, the impls do not appear to be used by the crate or its dependents. Removing them revealed some enum variants that are never constructed, too. r? @GuillaumeGomez
    
  Centril 
      added a commit
        to Centril/rust
      that referenced
      this pull request
    
      Jun 29, 2019 
    
    
      
  
    
      
    
  
…omez rustdoc: remove unused derives and variants Though many structs in rustdoc derive `RustcEncodable` and `RustcDecodable`, the impls do not appear to be used by the crate or its dependents. Removing them revealed some enum variants that are never constructed, too. r? @GuillaumeGomez
    
  Centril 
      added a commit
        to Centril/rust
      that referenced
      this pull request
    
      Jun 29, 2019 
    
    
      
  
    
      
    
  
…omez rustdoc: remove unused derives and variants Though many structs in rustdoc derive `RustcEncodable` and `RustcDecodable`, the impls do not appear to be used by the crate or its dependents. Removing them revealed some enum variants that are never constructed, too. r? @GuillaumeGomez
    
  Centril 
      added a commit
        to Centril/rust
      that referenced
      this pull request
    
      Jun 30, 2019 
    
    
      
  
    
      
    
  
…omez rustdoc: remove unused derives and variants Though many structs in rustdoc derive `RustcEncodable` and `RustcDecodable`, the impls do not appear to be used by the crate or its dependents. Removing them revealed some enum variants that are never constructed, too. r? @GuillaumeGomez
    
  bors 
      added a commit
      that referenced
      this pull request
    
      Jul 1, 2019 
    
    
      
  
    
      
    
  
Rollup of 8 pull requests Successful merges: - #62062 (Use a more efficient iteration order for forward dataflow) - #62063 (Use a more efficient iteration order for backward dataflow) - #62224 (rustdoc: remove unused derives and variants) - #62228 (Extend the #[must_use] lint to boxed types) - #62235 (Extend the `#[must_use]` lint to arrays) - #62239 (Fix a typo) - #62241 (Always parse 'async unsafe fn' + properly ban in 2015) - #62248 (before_exec actually will only get deprecated with 1.37) Failed merges: r? @ghost
  
    Sign up for free
    to join this conversation on GitHub.
    Already have an account?
    Sign in to comment
  
      Labels
      
    S-waiting-on-bors
  Status: Waiting on bors to run and complete tests. Bors will change the label on completion. 
  Add this suggestion to a batch that can be applied as a single commit.
  This suggestion is invalid because no changes were made to the code.
  Suggestions cannot be applied while the pull request is closed.
  Suggestions cannot be applied while viewing a subset of changes.
  Only one suggestion per line can be applied in a batch.
  Add this suggestion to a batch that can be applied as a single commit.
  Applying suggestions on deleted lines is not supported.
  You must change the existing code in this line in order to create a valid suggestion.
  Outdated suggestions cannot be applied.
  This suggestion has been applied or marked resolved.
  Suggestions cannot be applied from pending reviews.
  Suggestions cannot be applied on multi-line comments.
  Suggestions cannot be applied while the pull request is queued to merge.
  Suggestion cannot be applied right now. Please check back later.
  
    
  
    
Though many structs in rustdoc derive
RustcEncodableandRustcDecodable, the impls do not appear to be used by the crate or its dependents. Removing them revealed some enum variants that are never constructed, too.r? @GuillaumeGomez