Skip to content

Implement From<Local> for Place and PlaceBase #62096

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 25, 2019
Merged

Implement From<Local> for Place and PlaceBase #62096

merged 1 commit into from
Jun 25, 2019

Conversation

@spastorino
Copy link
Member

r? @oli-obk
More tiny bits of Place 2.0 moved into master

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jun 24, 2019
Centril
Centril reviewed Jun 24, 2019
View reviewed changes
oli-obk
oli-obk reviewed Jun 24, 2019
View reviewed changes
Copy link
Contributor

@oli-obk oli-obk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bors r+

@oli-obk
Copy link
Contributor

oli-obk commented Jun 24, 2019

@bors r+

@bors
Copy link
Collaborator

bors commented Jun 24, 2019

📌 Commit 1b8d41222b61cab08cb83c0f85a117b56c256e92 has been approved by oli-obk

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 24, 2019
@bors

This comment has been minimized.

Sign in to view
@bors bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Jun 24, 2019
@Centril
Copy link
Contributor

Centril commented Jun 25, 2019

@bors r=oli-obk,Centril

@bors
Copy link
Collaborator

bors commented Jun 25, 2019

📌 Commit 099f9e4 has been approved by oli-obk,Centril

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jun 25, 2019
Centril added a commit to Centril/rust that referenced this pull request Jun 25, 2019
@Centril
Rollup merge of rust-lang#62096 - spastorino:impl-place-from, r=oli-o…
d406d89 
…bk,Centril

Implement From<Local> for Place and PlaceBase

r? @oli-obk
More tiny bits of Place 2.0 moved into master
@Centril Centril mentioned this pull request Jun 25, 2019
Merged
bors added a commit that referenced this pull request Jun 25, 2019
@bors
Auto merge of #62119 - Centril:rollup-el20wu0, r=Centril
5f9c044 
Rollup of 7 pull requests

Successful merges:

 - #61814 (Fix an ICE with uninhabited consts)
 - #61987 (rustc: produce AST instead of HIR from `hir::lowering::Resolver` methods.)
 - #62055 (Fix error counting)
 - #62078 (Remove built-in derive macros `Send` and `Sync`)
 - #62085 (Add test for issue-38591)
 - #62091 (HirIdification: almost there)
 - #62096 (Implement From<Local> for Place and PlaceBase)

Failed merges:

r? @ghost
@bors bors merged commit 099f9e4 into rust-lang:master Jun 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@oli-obk oli-obk oli-obk left review comments

+1 more reviewer

@Centril Centril Centril left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@oli-obk oli-obk

Labels

S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@spastorino @oli-obk @bors @Centril @rust-highfive