- 
                Notifications
    You must be signed in to change notification settings 
- Fork 13.9k
ci: display more debug information in the init_repo script #61322
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
          
     Merged
      
      
            bors
  merged 1 commit into
  rust-lang:master
from
pietroalbini:debug-windows-submodule-cloning
  
      
      
   
  May 30, 2019 
      
    
                
     Merged
            
            ci: display more debug information in the init_repo script #61322
                    bors
  merged 1 commit into
  rust-lang:master
from
pietroalbini:debug-windows-submodule-cloning
  
      
      
   
  May 30, 2019 
              
            Conversation
  
    
      This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
      Learn more about bidirectional Unicode characters
    
  
  
    
    | @bors: r+ rollup | 
| 📌 Commit 5f4f368 has been approved by  | 
    
  Centril 
      added a commit
        to Centril/rust
      that referenced
      this pull request
    
      May 30, 2019 
    
    
      
  
    
      
    
  
…e-cloning, r=alexcrichton ci: display more debug information in the init_repo script I'm *really* confused about the error message [while cloning submodules on Windows on Azure](https://dev.azure.com/rust-lang/e71b0ddf-dd27-435a-873c-e30f86eea377/_apis/build/builds/295/logs/506): ``` /usr/bin/tar: You must specify one of the '-Acdtrux', '--delete' or '--test-label' options Try '/usr/bin/tar --help' or '/usr/bin/tar --usage' for more information. ``` It doesn't make sense for it to execute a command without any of those flags since they're clearly added: https://github.com/rust-lang/rust/blob/81970852e172c04322cbf8ba23effabeb491c83c/src/ci/init_repo.sh#L45 So this adds `set -x` to the script to hopefully catch what command it's executing. r? @alexcrichton cc rust-lang#61301
    
  Centril 
      added a commit
        to Centril/rust
      that referenced
      this pull request
    
      May 30, 2019 
    
    
      
  
    
      
    
  
…e-cloning, r=alexcrichton ci: display more debug information in the init_repo script I'm *really* confused about the error message [while cloning submodules on Windows on Azure](https://dev.azure.com/rust-lang/e71b0ddf-dd27-435a-873c-e30f86eea377/_apis/build/builds/295/logs/506): ``` /usr/bin/tar: You must specify one of the '-Acdtrux', '--delete' or '--test-label' options Try '/usr/bin/tar --help' or '/usr/bin/tar --usage' for more information. ``` It doesn't make sense for it to execute a command without any of those flags since they're clearly added: https://github.com/rust-lang/rust/blob/81970852e172c04322cbf8ba23effabeb491c83c/src/ci/init_repo.sh#L45 So this adds `set -x` to the script to hopefully catch what command it's executing. r? @alexcrichton cc rust-lang#61301
    
  bors 
      added a commit
      that referenced
      this pull request
    
      May 30, 2019 
    
    
      
  
    
      
    
  
Rollup of 11 pull requests Successful merges: - #60802 (upgrade rustdoc's `pulldown-cmark` to 0.5.2) - #60839 (Fix ICE with struct ctors and const generics.) - #60850 (Stabilize RefCell::try_borrow_unguarded) - #61231 (Fix linkage diagnostic so it doesn't ICE for external crates) - #61244 (Box::into_vec: use Box::into_raw instead of mem::forget) - #61279 (implicit `Option`-returning doctests) - #61280 (Revert "Disable solaris target since toolchain no longer builds") - #61284 (Update all s3 URLs used on CI with subdomains) - #61321 (libsyntax: introduce 'fn is_keyword_ahead(dist, keywords)'.) - #61322 (ci: display more debug information in the init_repo script) - #61333 (Fix ICE with APIT in a function with a const parameter) Failed merges: - #61304 (Speed up Azure CI installing Windows dependencies) r? @ghost
    
  bors 
      added a commit
      that referenced
      this pull request
    
      May 30, 2019 
    
    
      
  
    
      
    
  
Rollup of 11 pull requests Successful merges: - #60802 (upgrade rustdoc's `pulldown-cmark` to 0.5.2) - #60839 (Fix ICE with struct ctors and const generics.) - #60850 (Stabilize RefCell::try_borrow_unguarded) - #61231 (Fix linkage diagnostic so it doesn't ICE for external crates) - #61244 (Box::into_vec: use Box::into_raw instead of mem::forget) - #61279 (implicit `Option`-returning doctests) - #61280 (Revert "Disable solaris target since toolchain no longer builds") - #61284 (Update all s3 URLs used on CI with subdomains) - #61321 (libsyntax: introduce 'fn is_keyword_ahead(dist, keywords)'.) - #61322 (ci: display more debug information in the init_repo script) - #61333 (Fix ICE with APIT in a function with a const parameter) Failed merges: - #61304 (Speed up Azure CI installing Windows dependencies) r? @ghost
  
    Sign up for free
    to join this conversation on GitHub.
    Already have an account?
    Sign in to comment
  
      Labels
      
    S-waiting-on-bors
  Status: Waiting on bors to run and complete tests. Bors will change the label on completion. 
  Add this suggestion to a batch that can be applied as a single commit.
  This suggestion is invalid because no changes were made to the code.
  Suggestions cannot be applied while the pull request is closed.
  Suggestions cannot be applied while viewing a subset of changes.
  Only one suggestion per line can be applied in a batch.
  Add this suggestion to a batch that can be applied as a single commit.
  Applying suggestions on deleted lines is not supported.
  You must change the existing code in this line in order to create a valid suggestion.
  Outdated suggestions cannot be applied.
  This suggestion has been applied or marked resolved.
  Suggestions cannot be applied from pending reviews.
  Suggestions cannot be applied on multi-line comments.
  Suggestions cannot be applied while the pull request is queued to merge.
  Suggestion cannot be applied right now. Please check back later.
  
    
  
    
I'm really confused about the error message while cloning submodules on Windows on Azure:
It doesn't make sense for it to execute a command without any of those flags since they're clearly added:
rust/src/ci/init_repo.sh
Line 45 in 8197085
So this adds
set -xto the script to hopefully catch what command it's executing.r? @alexcrichton
cc #61301