Skip to content

Dont ICE on an attempt to use GAT without feature gate #61118

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
May 25, 2019
Merged

Dont ICE on an attempt to use GAT without feature gate #61118

merged 3 commits into from
May 25, 2019

Conversation

@pnkfelix
Copy link
Contributor

Fix #60654

@rust-highfive
Copy link
Contributor

r? @varkor

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label May 24, 2019
@varkor
Copy link
Contributor

varkor commented May 24, 2019

@bors r+

@bors
Copy link
Collaborator

bors commented May 24, 2019

📌 Commit c235ba4 has been approved by varkor

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels May 24, 2019
Centril added a commit to Centril/rust that referenced this pull request May 24, 2019
@Centril
Rollup merge of rust-lang#61118 - pnkfelix:issue-60654-dont-ice-on-ga…
85b7dbf 
…t, r=varkor

Dont ICE on an attempt to use GAT without feature gate

Fix rust-lang#60654
@Centril Centril mentioned this pull request May 24, 2019
Closed
Centril added a commit to Centril/rust that referenced this pull request May 24, 2019
@Centril
Rollup merge of rust-lang#61118 - pnkfelix:issue-60654-dont-ice-on-ga…
69da35b 
…t, r=varkor

Dont ICE on an attempt to use GAT without feature gate

Fix rust-lang#60654
@Centril Centril mentioned this pull request May 24, 2019
Closed
bors added a commit that referenced this pull request May 24, 2019
@bors
Auto merge of #61128 - Centril:rollup-rwjauqz, r=Centril
9bbf513 
Rollup of 13 pull requests

Successful merges:

 - #61077 (Don't arena-allocate static symbols.)
 - #61094 (Make find_local iterate instead of recurse)
 - #61095 (Update cargo)
 - #61096 (tidy: don't short-circuit on license error)
 - #61103 (Make find iterate instead of recurse)
 - #61104 (Make eval_place_to_op iterate instead of recurse)
 - #61107 (Fix a couple docs typos)
 - #61110 (Revert edition-guide toolstate override)
 - #61111 (Fixed type-alias-bounds lint doc)
 - #61113 (Deprecate `FnBox`. `Box<dyn FnOnce()>` can be called directly, since 1.35)
 - #61116 (Remove the incorrect warning from README.md)
 - #61118 (Dont ICE on an attempt to use GAT without feature gate)
 - #61125 (Updated my mailmap entry)

Failed merges:

r? @ghost
Centril added a commit to Centril/rust that referenced this pull request May 24, 2019
@Centril
Rollup merge of rust-lang#61118 - pnkfelix:issue-60654-dont-ice-on-ga…
35ccfc1 
…t, r=varkor

Dont ICE on an attempt to use GAT without feature gate

Fix rust-lang#60654
@Centril Centril mentioned this pull request May 24, 2019
Closed
Centril added a commit to Centril/rust that referenced this pull request May 25, 2019
@Centril
Rollup merge of rust-lang#61118 - pnkfelix:issue-60654-dont-ice-on-ga…
57139e2 
…t, r=varkor

Dont ICE on an attempt to use GAT without feature gate

Fix rust-lang#60654
@Centril Centril mentioned this pull request May 25, 2019
Merged
Centril added a commit to Centril/rust that referenced this pull request May 25, 2019
@Centril
Rollup merge of rust-lang#61150 - Centril:rollup-wmm7qga, r=Centril
fd8a334 
Rollup of 13 pull requests

Successful merges:

 - rust-lang#61026 (Tweak macro parse errors when reaching EOF during macro call parse)
 - rust-lang#61095 (Update cargo)
 - rust-lang#61096 (tidy: don't short-circuit on license error)
 - rust-lang#61107 (Fix a couple docs typos)
 - rust-lang#61110 (Revert edition-guide toolstate override)
 - rust-lang#61111 (Fixed type-alias-bounds lint doc)
 - rust-lang#61113 (Deprecate `FnBox`. `Box<dyn FnOnce()>` can be called directly, since 1.35)
 - rust-lang#61116 (Remove the incorrect warning from README.md)
 - rust-lang#61118 (Dont ICE on an attempt to use GAT without feature gate)
 - rust-lang#61121 (improve debug-printing of scalars)
 - rust-lang#61125 (Updated my mailmap entry)
 - rust-lang#61134 (Annotate each `reverse_bits` with `#[must_use]`)
 - rust-lang#61138 (Move async/await tests to their own folder)

Failed merges:

r? @ghost
bors added a commit that referenced this pull request May 25, 2019
@bors
Auto merge of #61150 - Centril:rollup-wmm7qga, r=Centril
315ab95 
Rollup of 13 pull requests

Successful merges:

 - #61026 (Tweak macro parse errors when reaching EOF during macro call parse)
 - #61095 (Update cargo)
 - #61096 (tidy: don't short-circuit on license error)
 - #61107 (Fix a couple docs typos)
 - #61110 (Revert edition-guide toolstate override)
 - #61111 (Fixed type-alias-bounds lint doc)
 - #61113 (Deprecate `FnBox`. `Box<dyn FnOnce()>` can be called directly, since 1.35)
 - #61116 (Remove the incorrect warning from README.md)
 - #61118 (Dont ICE on an attempt to use GAT without feature gate)
 - #61121 (improve debug-printing of scalars)
 - #61125 (Updated my mailmap entry)
 - #61134 (Annotate each `reverse_bits` with `#[must_use]`)
 - #61138 (Move async/await tests to their own folder)

Failed merges:

r? @ghost
@bors bors merged commit c235ba4 into rust-lang:master May 25, 2019
@pnkfelix pnkfelix mentioned this pull request Jun 14, 2019
Closed
@pnkfelix pnkfelix added beta-nominated Nominated for backporting to the compiler in the beta channel. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Jun 14, 2019
@pnkfelix
Copy link
Contributor Author

pnkfelix commented Jun 14, 2019 •
edited
Loading

beta nominating based on observation that this sometimes resolves an ICE on code that does not use the feature gate mentioned here (I think); see #56445.

@pnkfelix
Copy link
Contributor Author

discussed at T-compiler meeting. Accepting for beta-backport.

@pnkfelix pnkfelix added the beta-accepted Accepted for backporting to the compiler in the beta channel. label Jun 20, 2019
@pietroalbini pietroalbini mentioned this pull request Jun 22, 2019
Merged
@pietroalbini pietroalbini removed the beta-nominated Nominated for backporting to the compiler in the beta channel. label Jun 22, 2019
bors added a commit that referenced this pull request Jun 26, 2019
@bors
Auto merge of #62065 - pietroalbini:beta-rollup, r=Mark-Simulacrum
83167c4 
[beta] Rollup backports

Rolled up:

* [beta] Comment out dev key #61700

Cherry picked:

* Dont ICE on an attempt to use GAT without feature gate #61118
* Fix cfg(test) build for x86_64-fortanix-unknown-sgx #61503
* Handle index out of bound errors during const eval without panic #61598
* Hygienize macros in the standard library #61629
* Fix ICE involving mut references #61947
* rustc_typeck: correctly compute `Substs` for `Res::SelfCtor`. #61896
* Revert "Set test flag when rustdoc is running with --test option" #61199
* create a "provisional cache" to restore performance in the case of cycles #61754

r? @ghost
@pnkfelix pnkfelix mentioned this pull request Jul 9, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@varkor varkor

Labels

beta-accepted Accepted for backporting to the compiler in the beta channel. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

ICE with generic associated type

5 participants

@pnkfelix @rust-highfive @varkor @bors @pietroalbini