Skip to content

Breaking update of stdsimd #60162

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 25, 2019
Merged

Breaking update of stdsimd #60162

merged 1 commit into from
Apr 25, 2019

Conversation

gnzlbg
Copy link
Contributor

@gnzlbg gnzlbg commented Apr 22, 2019

This commit updates stdsimd and contains two breaking changes:

We already did a crater run of 586 but we should do another one here.

r? @alexcrichton

@gnzlbg
Breaking update of stdsimd
c9553f7 
This commit updates stdsimd and contains two breaking changes:

* rust-lang/stdarch#733
* rust-lang/stdarch#586

We already did a crater run of 586 but we should do another one here.
@rust-highfive
Copy link
Contributor

⚠️ Warning ⚠️

  • These commits modify submodules.

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Apr 22, 2019
@gnzlbg gnzlbg changed the title Breaking update of stdsimd [WIP] Breaking update of stdsimd Apr 22, 2019
@gnzlbg
Copy link
Contributor Author

gnzlbg commented Apr 22, 2019

Switching this to WIP: needs a crater run once CI is green.

@Centril
Copy link
Contributor

Centril commented Apr 22, 2019

@bors try

@bors
Copy link
Collaborator

bors commented Apr 22, 2019

⌛ Trying commit c9553f7 with merge 06a150c7d11500b41499224f165e9de1de096768...

@Centril
Copy link
Contributor

Centril commented Apr 22, 2019

Note to self: crater check-only when try completes.

@bors
Copy link
Collaborator

bors commented Apr 22, 2019

☀️ Try build successful - checks-travis
Build commit: 06a150c7d11500b41499224f165e9de1de096768

@Centril
Copy link
Contributor

Centril commented Apr 22, 2019

@craterbot run mode=check-only

@craterbot
Copy link
Collaborator

👌 Experiment pr-60162 created and queued.
🤖 Automatically detected try build 06a150c7d11500b41499224f165e9de1de096768
🔍 You can check out the queue and this experiment's details.

ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

@craterbot craterbot added S-waiting-on-crater Status: Waiting on a crater run to be completed. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 22, 2019
@craterbot
Copy link
Collaborator

🚧 Experiment pr-60162 is now running on agent aws-3-tmp.

ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

@craterbot
Copy link
Collaborator

🎉 Experiment pr-60162 is completed!
📊 0 regressed and 0 fixed (60951 total)
📰 Open the full report.

⚠️ If you notice any spurious failure please add them to the blacklist!
ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

@craterbot craterbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-crater Status: Waiting on a crater run to be completed. labels Apr 24, 2019
@Centril
Copy link
Contributor

Centril commented Apr 24, 2019

@gnzlbg Looking good!

@alexcrichton Let's move ahead?

@gnzlbg gnzlbg changed the title [WIP] Breaking update of stdsimd Breaking update of stdsimd Apr 24, 2019
@alexcrichton
Copy link
Member

@bors: r+

@bors
Copy link
Collaborator

bors commented Apr 24, 2019

📌 Commit c9553f7 has been approved by alexcrichton

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 24, 2019
@bors
Copy link
Collaborator

bors commented Apr 25, 2019

⌛ Testing commit c9553f7 with merge 3d720d7...

bors added a commit that referenced this pull request Apr 25, 2019
@bors
Auto merge of #60162 - gnzlbg:uss, r=alexcrichton
3d720d7 
Breaking update of stdsimd

This commit updates stdsimd and contains two breaking changes:

* rust-lang/stdarch#733
* rust-lang/stdarch#586

We already did a crater run of 586 but we should do another one here.

r? @alexcrichton
@bors
Copy link
Collaborator

bors commented Apr 25, 2019

☀️ Test successful - checks-travis, status-appveyor
Approved by: alexcrichton
Pushing 3d720d7 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Apr 25, 2019
@bors bors merged commit c9553f7 into rust-lang:master Apr 25, 2019
@pnkfelix pnkfelix mentioned this pull request Jun 21, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@alexcrichton alexcrichton

Labels
merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@gnzlbg @rust-highfive @Centril @bors @craterbot @alexcrichton