Skip to content

Conversation

JohnTitor
Copy link
Member

This is a draft

cc: #52790

r? @estebank

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Mar 24, 2019
@estebank
Copy link
Contributor

It's weird that your hoge error isn't being emitted. That makes me think that we're not touching the right code. I'll take a look at it later.

For now, I think that you're only changing the code for trait items, like

trait T {
    async fn foo() -> usize {}
}

but I think that will still not trigger because of it gets caught at missing_assoc_item_kind_err because of a fall-through for the trait declaration and an early return for the impl parsing, where the compiler thinks it should be parsing a macro.

@JohnTitor
Copy link
Member Author

yes, the expected error isn't appeared. If the process doesn't reach, we should touch other places, I think. What should I do?

@JohnTitor
Copy link
Member Author

@estebank Uh, Should I close this PR once, or work on?

@bors
Copy link
Collaborator

bors commented Apr 10, 2019

☔ The latest upstream changes (presumably #59810) made this pull request unmergeable. Please resolve the merge conflicts.

@estebank
Copy link
Contributor

@JohnTitor sorry for not being more responsive, I've been away for a couple of weeks.

If the process doesn't reach, we should touch other places, I think. What should I do?

I'll take a look at this sometimes this week to find where the right place to touch is, but you're certainly in the right "neighborhood".

@Mark-Simulacrum
Copy link
Member

@estebank Can you take a look at this PR again? It looks like @JohnTitor still needs some help.

@JohnTitor
Copy link
Member Author

I'm sorry but I can't have time to investigate at this time. Feel free to close this PR if we need to investigate more.

@Mark-Simulacrum
Copy link
Member

No worries! Let us know if you decide to re-investigate so we can reopen this pull request or you can also just open a new one.

@JohnTitor JohnTitor deleted the swapped-async-pub branch June 13, 2019 02:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants