Skip to content

[WIP] Place unroll -> iterate refactor #58819

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 4 commits into from
Closed

[WIP] Place unroll -> iterate refactor #58819

wants to merge 4 commits into from

Conversation

spastorino
Copy link
Member

Do not merge this is work in progress.

r? @oli-obk

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Feb 28, 2019
oli-obk
oli-obk reviewed Mar 11, 2019
View reviewed changes
src/librustc/mir/mod.rs
/// Iterator over components; see `PlaceProjections::iter` for more
/// information.
///
/// N.B., this is not a *true* Rust iterator -- the code above just
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What we could do is make it a real iterator and also implement https://doc.rust-lang.org/std/iter/trait.FusedIterator.html for that iterator. This way we guarantee that after the first None we keep getting Nones.

@oli-obk
Copy link
Contributor

oli-obk commented Mar 11, 2019

@spastorino this looks like a good intermediate step that we could merge before any further changes.

@Dylan-DPC-zz
Copy link

ping from triage @oli-obk any updates?

@oli-obk oli-obk added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 19, 2019
@spastorino
Copy link
Member Author

@Dylan-DPC I'm the one "working" on this. This is still in WIP, we need to land some stuff before. I'm slowly catching up with stuff but have been very busy.

@Dylan-DPC-zz
Copy link

thanks. I thought some part of the review was pending. Great :)

@bors
Copy link
Collaborator

bors commented Mar 26, 2019

☔ The latest upstream changes (presumably #59433) made this pull request unmergeable. Please resolve the merge conflicts.

@Centril
Copy link
Contributor

Centril commented Mar 30, 2019

Ping from triage, @spastorino What other stuff is this blocked on? what PRs if any?

@spastorino
Copy link
Member Author

@Centril blocked on https://rustlatam.org 😂. Now that the thing have finished I'm back to work on Place 2.0

@spastorino
Copy link
Member Author

Going to close this for now and reopen after I change Place to a struct

@spastorino spastorino closed this Apr 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oli-obk oli-obk oli-obk left review comments

Assignees

@oli-obk oli-obk

Labels
S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@spastorino @oli-obk @Dylan-DPC-zz @bors @Centril @rust-highfive