Skip to content

Partially HirId-ify rustc #58151

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 10, 2019
Merged

Partially HirId-ify rustc #58151

merged 1 commit into from
Feb 10, 2019

Conversation

@ljedrz
Copy link
Contributor

@ljedrz ljedrz commented Feb 4, 2019 •
edited
Loading

Another step towards #57578.

@rust-highfive
Copy link
Contributor

r? @michaelwoerister

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Feb 4, 2019
@Zoxc
Copy link
Contributor

Zoxc commented Feb 4, 2019

You don't need to make these PRs so small. Maybe aim for around 600 changed lines?

@ljedrz
Copy link
Contributor Author

ljedrz commented Feb 4, 2019

No worries; these changes are probably the last ones that can be so small and nicely self-contained ^^.

@Zoxc Zoxc assigned Zoxc and unassigned michaelwoerister Feb 4, 2019
@ljedrz
Copy link
Contributor Author

ljedrz commented Feb 5, 2019

Rebased.

@Zoxc
Copy link
Contributor

Zoxc commented Feb 5, 2019

@bors r+

@bors
Copy link
Collaborator

bors commented Feb 5, 2019

📌 Commit 8d6e5fc has been approved by Zoxc

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Feb 5, 2019
kennytm added a commit to kennytm/rust that referenced this pull request Feb 8, 2019
@kennytm
Rollup merge of rust-lang#58151 - ljedrz:HirIdify_rustc, r=Zoxc
5472c5f 
Partially HirId-ify rustc

Another step towards rust-lang#57578.
@kennytm kennytm mentioned this pull request Feb 8, 2019
Closed
@Mark-Simulacrum Mark-Simulacrum mentioned this pull request Feb 10, 2019
Closed
pietroalbini added a commit to pietroalbini/rust that referenced this pull request Feb 10, 2019
@pietroalbini
Rollup merge of rust-lang#58151 - ljedrz:HirIdify_rustc, r=Zoxc
384d918 
Partially HirId-ify rustc

Another step towards rust-lang#57578.
@pietroalbini pietroalbini mentioned this pull request Feb 10, 2019
Closed
@bors
Copy link
Collaborator

bors commented Feb 10, 2019

⌛ Testing commit 8d6e5fc with merge c3d2490...

bors added a commit that referenced this pull request Feb 10, 2019
@bors
Auto merge of #58151 - ljedrz:HirIdify_rustc, r=Zoxc
c3d2490 
Partially HirId-ify rustc

Another step towards #57578.
@bors
Copy link
Collaborator

bors commented Feb 10, 2019

☀️ Test successful - checks-travis, status-appveyor
Approved by: Zoxc
Pushing c3d2490 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Feb 10, 2019
@bors bors merged commit 8d6e5fc into rust-lang:master Feb 10, 2019
This was referenced Feb 10, 2019
Closed
Merged
@ljedrz ljedrz deleted the HirIdify_rustc branch February 10, 2019 17:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@Zoxc Zoxc

Labels

merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@ljedrz @rust-highfive @Zoxc @bors @michaelwoerister