Skip to content

Combine all builtin late lints and make lint checking parallel #58019

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Mar 29, 2019
Merged

Combine all builtin late lints and make lint checking parallel #58019

merged 3 commits into from
Mar 29, 2019

Conversation

Zoxc
Copy link
Contributor

@Zoxc Zoxc commented Jan 31, 2019

Blocked on #57293.

Cuts runtime of late lint checking from 3.222s to 0.546s with 8 threads on winapi (@retep998 ;) )

r? @estebank

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jan 31, 2019
@rust-highfive

This comment has been minimized.

Sign in to view
@Zoxc Zoxc force-pushed the combine-late-lints branch from 8d86971 to c76b767 Compare January 31, 2019 14:21
@estebank
Copy link
Contributor

r=me ++

@estebank estebank added S-blocked Status: Blocked on something else such as an RFC or other implementation work. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 31, 2019
@bors

This comment has been minimized.

Sign in to view
@Zoxc Zoxc force-pushed the combine-late-lints branch from c76b767 to abba103 Compare February 15, 2019 04:32
@bors

This comment has been minimized.

Sign in to view
@Zoxc Zoxc force-pushed the combine-late-lints branch from abba103 to 4b9290d Compare February 26, 2019 12:22
@bors

This comment has been minimized.

Sign in to view
@Zoxc Zoxc force-pushed the combine-late-lints branch from 4b9290d to 6ebb3cd Compare March 1, 2019 00:28
@bors

This comment has been minimized.

Sign in to view
@Zoxc Zoxc force-pushed the combine-late-lints branch from 6ebb3cd to 52f4e6b Compare March 1, 2019 20:15
@estebank
Copy link
Contributor

estebank commented Mar 1, 2019

@bors r+

@bors

This comment has been minimized.

Sign in to view
@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-blocked Status: Blocked on something else such as an RFC or other implementation work. labels Mar 1, 2019
@estebank
Copy link
Contributor

estebank commented Mar 1, 2019

@bors r- forgot this was blocked on #57293

@bors bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Mar 1, 2019
@Zoxc Zoxc mentioned this pull request Mar 8, 2019
Open
@bors

This comment has been minimized.

Sign in to view
@Zoxc Zoxc force-pushed the combine-late-lints branch from 52f4e6b to d57f98e Compare March 9, 2019 22:03
@bors

This comment has been minimized.

Sign in to view
@Zoxc Zoxc force-pushed the combine-late-lints branch from d57f98e to 4cab76e Compare March 10, 2019 10:24
@rust-highfive

This comment has been minimized.

Sign in to view
@bors

This comment has been minimized.

Sign in to view
@Zoxc Zoxc force-pushed the combine-late-lints branch from 4cab76e to 86d8c49 Compare March 13, 2019 01:58
@bors

This comment has been minimized.

Sign in to view
@Zoxc Zoxc force-pushed the combine-late-lints branch from 86d8c49 to 5eb24ed Compare March 14, 2019 16:14
@Zoxc Zoxc mentioned this pull request Mar 15, 2019
Merged
@Zoxc
Copy link
Contributor Author

Zoxc commented Mar 18, 2019

@bors try

@bors
Copy link
Collaborator

bors commented Mar 18, 2019

⌛ Trying commit 5eb24edc8d9921231ec8589c1f9d1e16489711a2 with merge eaad254355cc991c01011b6327e9cf27bfad670c...

@bors
Copy link
Collaborator

bors commented Mar 18, 2019

☀️ Try build successful - checks-travis
Build commit: eaad254355cc991c01011b6327e9cf27bfad670c

@Zoxc
Copy link
Contributor Author

Zoxc commented Mar 18, 2019

@rust-timer build eaad254355cc991c01011b6327e9cf27bfad670c

@rust-timer
Copy link
Collaborator

Success: Queued eaad254355cc991c01011b6327e9cf27bfad670c with parent 0f88167, comparison URL.

@rust-timer
Copy link
Collaborator

Finished benchmarking try commit eaad254355cc991c01011b6327e9cf27bfad670c

@estebank estebank added the S-blocked Status: Blocked on something else such as an RFC or other implementation work. label Mar 22, 2019
@Zoxc Zoxc force-pushed the combine-late-lints branch from 5eb24ed to dee389f Compare March 28, 2019 15:34
@Zoxc
Copy link
Contributor Author

Zoxc commented Mar 28, 2019

@bors r=estebank

@bors
Copy link
Collaborator

bors commented Mar 28, 2019

📌 Commit dee389f has been approved by estebank

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-blocked Status: Blocked on something else such as an RFC or other implementation work. S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Mar 28, 2019
Centril added a commit to Centril/rust that referenced this pull request Mar 29, 2019
@Centril
Rollup merge of rust-lang#58019 - Zoxc:combine-late-lints, r=estebank
8794e21 
Combine all builtin late lints and make lint checking parallel

Blocked on rust-lang#57293.

Cuts runtime of late lint checking from 3.222s to 0.546s with 8 threads on `winapi` (@retep998 ;) )

r? @estebank
@Centril Centril mentioned this pull request Mar 29, 2019
Merged
bors added a commit that referenced this pull request Mar 29, 2019
@bors
Auto merge of #59513 - Centril:rollup, r=Centril
41dee75 
Rollup of 11 pull requests

Successful merges:

 - #58019 (Combine all builtin late lints and make lint checking parallel)
 - #59358 (Use `track_errors` instead of hand rolling)
 - #59394 (warn -> deny duplicate match bindings)
 - #59401 (bootstrap: build crates under libtest with -Z emit-stack-sizes)
 - #59423 (Visit path in `walk_mac`)
 - #59468 (musl: build toolchain libs with -fPIC)
 - #59476 (Use `SmallVec` in `TokenStreamBuilder`.)
 - #59496 (Remove unnecessary with_globals calls)
 - #59498 (Use 'write_all' instead of 'write' in example code)
 - #59503 (Stablize {f32,f64}::copysign().)
 - #59511 (Fix missed fn rename in #59284)

Failed merges:

r? @ghost
bors added a commit that referenced this pull request Mar 29, 2019
@bors
Auto merge of #59513 - Centril:rollup, r=Centril
003382e 
Rollup of 11 pull requests

Successful merges:

 - #58019 (Combine all builtin late lints and make lint checking parallel)
 - #59358 (Use `track_errors` instead of hand rolling)
 - #59394 (warn -> deny duplicate match bindings)
 - #59401 (bootstrap: build crates under libtest with -Z emit-stack-sizes)
 - #59423 (Visit path in `walk_mac`)
 - #59468 (musl: build toolchain libs with -fPIC)
 - #59476 (Use `SmallVec` in `TokenStreamBuilder`.)
 - #59496 (Remove unnecessary with_globals calls)
 - #59498 (Use 'write_all' instead of 'write' in example code)
 - #59503 (Stablize {f32,f64}::copysign().)
 - #59511 (Fix missed fn rename in #59284)

Failed merges:

r? @ghost
@bors bors merged commit dee389f into rust-lang:master Mar 29, 2019
@Zoxc Zoxc deleted the combine-late-lints branch March 29, 2019 14:41
@aturon aturon mentioned this pull request Aug 16, 2019
Open
37 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@estebank estebank

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Zoxc @rust-highfive @estebank @bors @rust-timer