- 
                Notifications
    You must be signed in to change notification settings 
- Fork 13.9k
rustdoc: Fix local reexports of proc macros #56637
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
          
     Merged
      
      
            bors
  merged 1 commit into
  rust-lang:master
from
ollie27:rustdoc_proc_macro_local_reexport
  
      
      
   
  Dec 14, 2018 
      
    
                
     Merged
            
            rustdoc: Fix local reexports of proc macros #56637
                    bors
  merged 1 commit into
  rust-lang:master
from
ollie27:rustdoc_proc_macro_local_reexport
  
      
      
   
  Dec 14, 2018 
              
            
      
        
          +19
        
        
          −4
        
        
          
        
      
    
  
Conversation
  
    
      This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
      Learn more about bidirectional Unicode characters
    
  
  
    
    Filter out `ProcMacroStub`s to avoid an ICE during cleaning. Also add proc macros to `cache().paths` so it can generate links.
              
                    QuietMisdreavus
  
              
              approved these changes
              
                  
                    Dec 10, 2018 
                  
              
              
            
            
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
| @bors r+ | 
| 📌 Commit 0bb075f has been approved by  | 
    
  pietroalbini 
      added a commit
        to pietroalbini/rust
      that referenced
      this pull request
    
      Dec 11, 2018 
    
    
      
  
    
      
    
  
…export, r=QuietMisdreavus rustdoc: Fix local reexports of proc macros Filter out `ProcMacroStub`s to avoid an ICE during cleaning. Also add proc macros to `cache().paths` so it can generate links. r? @QuietMisdreavus
    
  kennytm 
      added a commit
        to kennytm/rust
      that referenced
      this pull request
    
      Dec 12, 2018 
    
    
      
  
    
      
    
  
…export, r=QuietMisdreavus rustdoc: Fix local reexports of proc macros Filter out `ProcMacroStub`s to avoid an ICE during cleaning. Also add proc macros to `cache().paths` so it can generate links. r? @QuietMisdreavus
    
  kennytm 
      added a commit
        to kennytm/rust
      that referenced
      this pull request
    
      Dec 13, 2018 
    
    
      
  
    
      
    
  
…export, r=QuietMisdreavus rustdoc: Fix local reexports of proc macros Filter out `ProcMacroStub`s to avoid an ICE during cleaning. Also add proc macros to `cache().paths` so it can generate links. r? @QuietMisdreavus
    
  kennytm 
      added a commit
        to kennytm/rust
      that referenced
      this pull request
    
      Dec 14, 2018 
    
    
      
  
    
      
    
  
…export, r=QuietMisdreavus rustdoc: Fix local reexports of proc macros Filter out `ProcMacroStub`s to avoid an ICE during cleaning. Also add proc macros to `cache().paths` so it can generate links. r? @QuietMisdreavus
  This was referenced Dec 14, 2018 
      
    
  bors 
      added a commit
      that referenced
      this pull request
    
      Dec 14, 2018 
    
    
      
  
    
      
    
  
Rollup of 14 pull requests (first batch) Successful merges: - #56562 (Update libc version required by rustc) - #56609 (Unconditionally emit the target-cpu LLVM attribute.) - #56637 (rustdoc: Fix local reexports of proc macros) - #56658 (Add non-panicking `maybe_new_parser_from_file` variant) - #56695 (Fix irrefutable matches on integer ranges) - #56699 (Use a `newtype_index!` within `Symbol`.) - #56702 ([self-profiler] Add column for percent of total time) - #56708 (Remove some unnecessary feature gates) - #56709 (Remove unneeded extra chars to reduce search-index size) - #56744 (specialize: remove Boxes used by Children::insert) - #56748 (Update panic message to be clearer about env-vars) - #56749 (x86: Add the `adx` target feature to whitelist) - #56756 (Disable btree pretty-printers on older gdbs) - #56789 (rustc: Add an unstable `simd_select_bitmask` intrinsic) r? @ghost
  
    Sign up for free
    to join this conversation on GitHub.
    Already have an account?
    Sign in to comment
  
      Labels
      
    S-waiting-on-bors
  Status: Waiting on bors to run and complete tests. Bors will change the label on completion. 
  Add this suggestion to a batch that can be applied as a single commit.
  This suggestion is invalid because no changes were made to the code.
  Suggestions cannot be applied while the pull request is closed.
  Suggestions cannot be applied while viewing a subset of changes.
  Only one suggestion per line can be applied in a batch.
  Add this suggestion to a batch that can be applied as a single commit.
  Applying suggestions on deleted lines is not supported.
  You must change the existing code in this line in order to create a valid suggestion.
  Outdated suggestions cannot be applied.
  This suggestion has been applied or marked resolved.
  Suggestions cannot be applied from pending reviews.
  Suggestions cannot be applied on multi-line comments.
  Suggestions cannot be applied while the pull request is queued to merge.
  Suggestion cannot be applied right now. Please check back later.
  
    
  
    
Filter out
ProcMacroStubs to avoid an ICE during cleaning.Also add proc macros to
cache().pathsso it can generate links.r? @QuietMisdreavus