HybridIdxSet tweaks
#53656
Merged
HybridIdxSet tweaks
#53656
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rust-highfive
added
the
S-waiting-on-review
nikomatsakis
approved these changes
Aug 24, 2018
src/librustc_mir/dataflow/mod.rs
Outdated
| /// For each block, bits valid on entry to the block. | ||
| on_entry_sets: Bits<E>, | ||
| on_entry_sets: Vec<IdxSetBuf<E>>, |
There was a problem hiding this comment.
didn't I already review this? Am I just getting confused...
| fn new(init: Word, universe_size: usize) -> Self { | ||
| let num_words = (universe_size + (BITS_PER_WORD - 1)) / BITS_PER_WORD; | ||
| fn new(init: Word, domain_size: usize) -> Self { | ||
| let num_words = (domain_size + (BITS_PER_WORD - 1)) / BITS_PER_WORD; |
|
@bors r=nnethercote |
|
📌 Commit f52c0b93e45def9e5c5010f3d90a9156afac4110 has been approved by |
bors
added
S-waiting-on-bors
|
@bors r- |
bors
added
S-waiting-on-author
|
@bors delegate=nnethercote |
|
✌️ @nnethercote can now approve this pull request |
|
Oh, I mismanaged this branch... the first three commits already landed in #53520. It's just the last two commits that are new. Sorry for the confusion. |
Because `domain` is a more obvious term than `universe` for this concept.
They let `union()`, `union_sparse()` and `union_hybrid()` be merged. Likewise for subtract()`, `subtract_sparse()` and `subtract_hybrid()`.
nnethercote
force-pushed
the
HybridIdxSet-tweaks
branch
from
f52c0b9 to
626b298
Compare
|
@bors r=nikomatsakis |
|
📌 Commit 626b298 has been approved by |
bors
added
S-waiting-on-bors
bors
added a commit
that referenced
this pull request
Aug 27, 2018
`HybridIdxSet` tweaks A couple of tweaks to `HybridIdxSet`. r? @nikomatsakis
|
☀️ Test successful - status-appveyor, status-travis |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A couple of tweaks to
HybridIdxSet.r? @nikomatsakis