Skip to content

Conversation

oli-obk
Copy link
Contributor

@oli-obk oli-obk commented Jul 3, 2018

No description provided.

@rust-highfive
Copy link
Contributor

warning Warning warning

  • These commits modify submodules.

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jul 3, 2018
@kennytm
Copy link
Member

kennytm commented Jul 3, 2018

@bors r+ p=1

@bors
Copy link
Collaborator

bors commented Jul 3, 2018

📌 Commit 0c8ebae88f7a74f9304c10ab8da29178971f6c31 has been approved by kennytm

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 3, 2018
@oli-obk
Copy link
Contributor Author

oli-obk commented Jul 3, 2018

@bors r-

broken again

@bors bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Jul 3, 2018
@bors
Copy link
Collaborator

bors commented Jul 3, 2018

⌛ Testing commit 0c8ebae88f7a74f9304c10ab8da29178971f6c31 with merge 1f82a2f8e3c0c4c28304c0219f360faac85c3197...

@oli-obk
Copy link
Contributor Author

oli-obk commented Jul 3, 2018

race condition with bors

@bors r-

@oli-obk oli-obk force-pushed the clippy branch 2 times, most recently from 1c4583c to c465177 Compare July 3, 2018 16:44
@oli-obk
Copy link
Contributor Author

oli-obk commented Jul 3, 2018

@bors r=kennytm

@bors
Copy link
Collaborator

bors commented Jul 3, 2018

📌 Commit c465177f0d430916a47184d82ae41d31549facc6 has been approved by kennytm

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jul 3, 2018
@oli-obk
Copy link
Contributor Author

oli-obk commented Jul 3, 2018

@bors p=1

@bors
Copy link
Collaborator

bors commented Jul 3, 2018

⌛ Testing commit c465177f0d430916a47184d82ae41d31549facc6 with merge e4b1f10f9b49a8036af909b20c4abc2605058e29...

@bors
Copy link
Collaborator

bors commented Jul 3, 2018

💔 Test failed - status-travis

@rust-highfive

This comment has been minimized.

@bors bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Jul 3, 2018
@kennytm
Copy link
Member

kennytm commented Jul 3, 2018

@bors retry

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 3, 2018
@kennytm kennytm added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 4, 2018
@mati865 mati865 mentioned this pull request Jul 5, 2018
@oli-obk
Copy link
Contributor Author

oli-obk commented Jul 5, 2018

didn't update the submodule branch correctly. Idk why git didn't tell me I pushed to a nonexistant repository.

@bors r=kennytm p=1

@bors
Copy link
Collaborator

bors commented Jul 5, 2018

📌 Commit 216af09f03c34622c23b2bea81b8aa0a077a4d54 has been approved by kennytm

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jul 5, 2018
@bors
Copy link
Collaborator

bors commented Jul 5, 2018

⌛ Testing commit 216af09f03c34622c23b2bea81b8aa0a077a4d54 with merge 125ef193ab12df2e5228e5adb98c47657e211edd...

@bors
Copy link
Collaborator

bors commented Jul 5, 2018

💔 Test failed - status-appveyor

@bors bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Jul 5, 2018
@rust-highfive

This comment has been minimized.

@oli-obk
Copy link
Contributor Author

oli-obk commented Jul 5, 2018

`clippy-driver` enabled features ["consoleapi", "dbghelp", "errhandlingapi", "fileapi", "handleapi", "ioapiset", "jobapi", "jobapi2", "minwindef", "namedpipeapi", "ntdef", "ntstatus", "processenv", "processthreadsapi", "psapi", "std", "synchapi", "winbase", "wincon", "winerror", "winnt", "winsock2", "ws2def", "ws2ipdef", "ws2tcpip"] at "C:\\projects\\rust\\build\\x86_64-pc-windows-msvc\\stage2-tools\\x86_64-pc-windows-msvc\\release\\deps\\libwinapi-40d1e0056a1952e2.rlib"
        `cargo` enabled features ["consoleapi", "dbghelp", "errhandlingapi", "fileapi", "handleapi", "ioapiset", "jobapi", "jobapi2", "lmcons", "minschannel", "minwinbase", "minwindef", "namedpipeapi", "ntdef", "ntsecapi", "ntstatus", "processenv", "processthreadsapi", "profileapi", "psapi", "schannel", "securitybaseapi", "std", "synchapi", "sysinfoapi", "timezoneapi", "winbase", "wincon", "wincrypt", "winerror", "winnt", "winsock2", "ws2def", "ws2ipdef", "ws2tcpip"] at "C:\\projects\\rust\\build\\x86_64-pc-windows-msvc\\stage2-tools\\x86_64-pc-windows-msvc\\release\\deps\\libwinapi-9ad16dd87cb456ff.rlib"
  backtrace 0.3.6 (registry+https://github.com/rust-lang/crates.io-index)
    `clippy-driver` enabled features ["backtrace-sys", "coresymbolication", "dbghelp", "default", "dladdr", "libbacktrace", "libunwind", "winapi"] at "C:\\projects\\rust\\build\\x86_64-pc-windows-msvc\\stage2-tools\\x86_64-pc-windows-msvc\\release\\deps\\libbacktrace-45cac02f5b922b74.rlib"
            `cargo` enabled features ["backtrace-sys", "coresymbolication", "dbghelp", "default", "dladdr", "libbacktrace", "libunwind", "winapi"] at "C:\\projects\\rust\\build\\x86_64-pc-windows-msvc\\stage2-tools\\x86_64-pc-windows-msvc\\release\\deps\\libbacktrace-077f9cc432fa29ca.rlib"
  error-chain 0.11.0 (registry+https://github.com/rust-lang/crates.io-index)
    `clippy-driver` enabled features ["backtrace", "default", "example_generated"] at "C:\\projects\\rust\\build\\x86_64-pc-windows-msvc\\stage2-tools\\x86_64-pc-windows-msvc\\release\\deps\\liberror_chain-544a13b19deb0c2e.rlib"
              `rls` enabled features ["backtrace", "default", "example_generated"] at "C:\\projects\\rust\\build\\x86_64-pc-windows-msvc\\stage2-tools\\x86_64-pc-windows-msvc\\release\\deps\\liberror_chain-c2e71ab2abf62ca9.rlib"
  cargo_metadata 0.5.4 (registry+https://github.com/rust-lang/crates.io-index)
    `clippy-driver` enabled features [] at "C:\\projects\\rust\\build\\x86_64-pc-windows-msvc\\stage2-tools\\x86_64-pc-windows-msvc\\release\\deps\\libcargo_metadata-05e46730787288a8.rlib"
              `rls` enabled features [] at "C:\\projects\\rust\\build\\x86_64-pc-windows-msvc\\stage2-tools\\x86_64-pc-windows-msvc\\release\\deps\\libcargo_metadata-b84ca0904d7314c8.rlib"

still a diff even though I copied the features 1:1 from cargo :/

@oli-obk
Copy link
Contributor Author

oli-obk commented Jul 5, 2018

@bors r=kennytm p=1

manually transcribed missing features

@bors
Copy link
Collaborator

bors commented Jul 5, 2018

📌 Commit d5dbeda has been approved by kennytm

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 5, 2018
@bors
Copy link
Collaborator

bors commented Jul 5, 2018

⌛ Testing commit d5dbeda with merge 94eb176...

bors added a commit that referenced this pull request Jul 5, 2018
Update the clippy submodule
@rust-highfive

This comment has been minimized.

@bors
Copy link
Collaborator

bors commented Jul 5, 2018

☀️ Test successful - status-appveyor, status-travis
Approved by: kennytm
Pushing 94eb176 to master...

@bors bors merged commit d5dbeda into rust-lang:master Jul 5, 2018
@rust-highfive
Copy link
Contributor

📣 Toolstate changed by #52012!

Tested on commit 94eb176.
Direct link to PR: #52012

🎉 clippy-driver on windows: build-fail → test-pass.
🎉 clippy-driver on linux: build-fail → test-pass.

rust-highfive added a commit to rust-lang-nursery/rust-toolstate that referenced this pull request Jul 5, 2018
Tested on commit rust-lang/rust@94eb176.
Direct link to PR: <rust-lang/rust#52012>

🎉 clippy-driver on windows: build-fail → test-pass.
🎉 clippy-driver on linux: build-fail → test-pass.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants