Omitted the walks in visit_expr() and visit_stmt() #51993
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @oli-obk (or someone else) soon. If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes. Please see the contribution instructions for more information. |
rust-highfive
added
the
S-waiting-on-review
|
The job Click to expand the log.I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact |
|
The job Click to expand the log.I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact |
|
The job Click to expand the log.I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact |
|
The job Click to expand the log.I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact |
|
The job Click to expand the log.I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact |
|
The job Click to expand the log.I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact |
|
The job Click to expand the log.I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact |
|
Hmm... curious, it fails on paths. Try adding |
|
The job Click to expand the log.I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact |
oli-obk
reviewed
Jul 4, 2018
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
oli-obk
reviewed
Jul 4, 2018
There was a problem hiding this comment.
you don't need this match, it should be fine to call v.visit_expr(index) directly, if that fails, use v.visit_expr(&**index) to force a deref.
That transformation can be applied to all the match statements you used for reference conversions
oli-obk
reviewed
Jul 4, 2018
There was a problem hiding this comment.
this match is also unnecessary
|
The job Click to expand the log.I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact |
oli-obk
requested changes
Jul 4, 2018
There was a problem hiding this comment.
you need to recurse into the fields of these three matches, too
There was a problem hiding this comment.
you also need to recurse into the other fields of arm
There was a problem hiding this comment.
you need to visit all block statements, too. it would probably be better to create a visit_block function and call that one with the block as an argument, because then you can reuse it below in ExprLoop and above in ExprBlock
There was a problem hiding this comment.
you can merge ExprBreak and ExprRet by making ref _destination be _
There was a problem hiding this comment.
you can merge this with ExprAssignOp by making ref _binop be _
|
The job Click to expand the log.I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact |
|
The job Click to expand the log.I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact |
|
The job Click to expand the log.I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact |
|
The job Click to expand the log.I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact |
oli-obk
requested changes
Jul 5, 2018
There was a problem hiding this comment.
you lost the v.promotable = false; here
There was a problem hiding this comment.
v.promotable = false; missing here
There was a problem hiding this comment.
you lost the v.promotable = false; here
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
There was a problem hiding this comment.
v.promotable = false; missing here
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
There was a problem hiding this comment.
v.promotable = false; missing here
|
The job Click to expand the log.I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact |
oli-obk
requested changes
Jul 5, 2018
There was a problem hiding this comment.
can you add a line-break between those two closing bracket?
There was a problem hiding this comment.
rename argument to block and remove the match
There was a problem hiding this comment.
remove this nop-match, too. just use v.visit_expr(&arm.body)
There was a problem hiding this comment.
fix indentation and newlines here
|
The job Click to expand the log.I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact |
oli-obk
reviewed
Jul 5, 2018
There was a problem hiding this comment.
uh.... please don't match again, just reuse the arguments you already pattern matched (expr and hirvec_arm), or rename these to discr and arms
oli-obk
reviewed
Jul 5, 2018
There was a problem hiding this comment.
uhm... what is this line doing here?
oli-obk
reviewed
Jul 5, 2018
oli-obk
reviewed
Jul 5, 2018
oli-obk
reviewed
Jul 5, 2018
There was a problem hiding this comment.
This v.promotable = false is wrong
oli-obk
reviewed
Jul 6, 2018
oli-obk
reviewed
Jul 6, 2018
oli-obk
reviewed
Jul 6, 2018
oli-obk
reviewed
Jul 6, 2018
|
The job Click to expand the log.I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact |
oli-obk
reviewed
Jul 6, 2018
There was a problem hiding this comment.
Style nit: add a space before the Check
oli-obk
approved these changes
Jul 7, 2018
|
@bors r+ |
|
📌 Commit f629eb3 has been approved by |
bors
added
S-waiting-on-bors
|
⌛ Testing commit f629eb3 with merge 6b5e396c75db3b28c842d88d39af65afd516fb9b... |
|
💔 Test failed - status-travis |
bors
added
S-waiting-on-review
|
The job Click to expand the log.I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact |
1 similar comment
|
The job Click to expand the log.I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact |
|
Looks like a spurious network failure. |
bors
added
S-waiting-on-bors
bors
added a commit
that referenced
this pull request
Jul 7, 2018
Omitted the walks in visit_expr() and visit_stmt() @oli-obk
|
☀️ Test successful - status-appveyor, status-travis |
eddyb
reviewed
Jul 12, 2018
| } | ||
| } | ||
|
|
||
| impl<'a, 'tcx> Visitor<'tcx> for CheckCrateVisitor<'a, 'tcx> { |
There was a problem hiding this comment.
I should note that this part of the change makes no sense without #52318.
Please motivate such changes better in the future, using the PR description.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@oli-obk