- 
                Notifications
    You must be signed in to change notification settings 
- Fork 13.9k
          add outlives annotations to BTreeMap
          #51914
        
          New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
          
     Merged
      
      
            bors
  merged 1 commit into
  rust-lang:master
from
nikomatsakis:nll-fix-issue-issue-btreemap-annotations
  
      
      
   
  Jul 3, 2018 
      
    
                
     Merged
            
            
  
    add outlives annotations to BTreeMap
  
  #51914
              
                    bors
  merged 1 commit into
  rust-lang:master
from
nikomatsakis:nll-fix-issue-issue-btreemap-annotations
  
      
      
   
  Jul 3, 2018 
              
            Conversation
  
    
      This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
      Learn more about bidirectional Unicode characters
    
  
  
    
    | ☔ The latest upstream changes (presumably #51569) made this pull request unmergeable. Please resolve the merge conflicts. | 
| weird r=me | 
nll requires these annotations, I believe because of rust-lang#29149
8270dac    to
    59f2edb      
    Compare
  
    | @bors r=gankro | 
| 📌 Commit 59f2edb has been approved by  | 
| @bors rollup | 
    
  Mark-Simulacrum 
      added a commit
        to Mark-Simulacrum/rust
      that referenced
      this pull request
    
      Jul 2, 2018 
    
    
      
  
    
      
    
  
…reemap-annotations, r=gankro add outlives annotations to `BTreeMap` NLL requires these annotations, I believe because of <rust-lang#29149>. Fixes rust-lang#48224 r? @gankro cc @lqd
    
  pietroalbini 
      added a commit
        to pietroalbini/rust
      that referenced
      this pull request
    
      Jul 3, 2018 
    
    
      
  
    
      
    
  
…reemap-annotations, r=gankro add outlives annotations to `BTreeMap` NLL requires these annotations, I believe because of <rust-lang#29149>. Fixes rust-lang#48224 r? @gankro cc @lqd
    
  pietroalbini 
      added a commit
        to pietroalbini/rust
      that referenced
      this pull request
    
      Jul 3, 2018 
    
    
      
  
    
      
    
  
…reemap-annotations, r=gankro add outlives annotations to `BTreeMap` NLL requires these annotations, I believe because of <rust-lang#29149>. Fixes rust-lang#48224 r? @gankro cc @lqd
    
  bors 
      added a commit
      that referenced
      this pull request
    
      Jul 3, 2018 
    
    
      
  
    
      
    
  
Rollup of 13 pull requests Successful merges: - #51548 (Initialize LLVM's AMDGPU target machine, if available.) - #51809 (Add read_exact_at and write_all_at methods to FileExt on unix) - #51914 (add outlives annotations to `BTreeMap`) - #51958 (Show known meta items in unknown meta items error) - #51973 (Make Stdio handle UnwindSafe) - #51977 (bootstrap: tests should use rustc from config.toml) - #51978 (Do not suggest changes to str literal if it isn't one) - #51979 (Get rid of `TyImplTraitExistential`) - #51980 (Emit column info in debuginfo for non msvc like targets) - #51982 (incr.comp.: Take names of children into account when computing the ICH of a module's HIR.) - #51997 (add entry for cargo-metadata feature to RELEASES) - #52004 (toolstate: Fixed detection of changed submodule, and other fixes.) - #52006 ( Change --keep-stage to apply more often) Failed merges: r? @ghost
  
    Sign up for free
    to join this conversation on GitHub.
    Already have an account?
    Sign in to comment
  
      Labels
      
    S-waiting-on-bors
  Status: Waiting on bors to run and complete tests. Bors will change the label on completion. 
  Add this suggestion to a batch that can be applied as a single commit.
  This suggestion is invalid because no changes were made to the code.
  Suggestions cannot be applied while the pull request is closed.
  Suggestions cannot be applied while viewing a subset of changes.
  Only one suggestion per line can be applied in a batch.
  Add this suggestion to a batch that can be applied as a single commit.
  Applying suggestions on deleted lines is not supported.
  You must change the existing code in this line in order to create a valid suggestion.
  Outdated suggestions cannot be applied.
  This suggestion has been applied or marked resolved.
  Suggestions cannot be applied from pending reviews.
  Suggestions cannot be applied on multi-line comments.
  Suggestions cannot be applied while the pull request is queued to merge.
  Suggestion cannot be applied right now. Please check back later.
  
    
  
    
NLL requires these annotations, I believe because of #29149.
Fixes #48224
r? @gankro
cc @lqd