Skip to content

Lowering cleanups [2/N] #51815

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jun 27, 2018
Merged

Lowering cleanups [2/N] #51815

merged 2 commits into from
Jun 27, 2018

Conversation

oli-obk
Copy link
Contributor

@oli-obk oli-obk commented Jun 26, 2018

Double indirections are unnecessary

@rust-highfive
Copy link
Contributor

r? @pnkfelix

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jun 26, 2018
@Mark-Simulacrum
Copy link
Member

@bors try

We should benchmark this

bors added a commit that referenced this pull request Jun 26, 2018
@bors
Auto merge of #51815 - oli-obk:lowering_cleanups2, r=<try>
cd6ea61 
Lowering cleanups [2/N]

Double indirections are unnecessary
@bors
Copy link
Collaborator

bors commented Jun 26, 2018

⌛ Trying commit e65947d with merge cd6ea61...

@bors
Copy link
Collaborator

bors commented Jun 26, 2018

☀️ Test successful - status-travis
State: approved= try=True

@nikomatsakis
Copy link
Contributor

r? @nikomatsakis

(@pnkfelix is not available right now)

@Mark-Simulacrum
Copy link
Member

Link when perf is done: https://perf.rust-lang.org/compare.html?start=2808460e0f8082ac2724c9809d27990ca9cfefd8&end=cd6ea61038a3f140c638560c4d1f9da951e382a4&stat=instructions%3Au

@nikomatsakis
Copy link
Contributor

@bors r+

This actually shows some small wins (2% on syn), which I didn't really expect I have to admit. ;)

@bors
Copy link
Collaborator

bors commented Jun 26, 2018

📌 Commit e65947d has been approved by nikomatsakis

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 26, 2018
@bors
Copy link
Collaborator

bors commented Jun 27, 2018

⌛ Testing commit e65947d with merge 971f7d3...

bors added a commit that referenced this pull request Jun 27, 2018
@bors
Auto merge of #51815 - oli-obk:lowering_cleanups2, r=nikomatsakis
971f7d3 
Lowering cleanups [2/N]

Double indirections are unnecessary
@bors
Copy link
Collaborator

bors commented Jun 27, 2018

☀️ Test successful - status-appveyor, status-travis
Approved by: nikomatsakis
Pushing 971f7d3 to master...

@bors bors merged commit e65947d into rust-lang:master Jun 27, 2018
@oli-obk oli-obk deleted the lowering_cleanups2 branch June 15, 2020 15:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nikomatsakis nikomatsakis nikomatsakis approved these changes

Assignees

@nikomatsakis nikomatsakis

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@oli-obk @rust-highfive @Mark-Simulacrum @bors @nikomatsakis @pnkfelix