Fixes some style issues in rustdoc "implementations on Foreign types" #51193
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rust-highfive
added
the
S-waiting-on-review
GuillaumeGomez
force-pushed
the
fixes-style-issues
branch
from
027d313 to
c7312fb
Compare
|
Do you have a screenshot with the new change? |
|
I'll this evening. But It's mostly style fixes. |
|
Here it is:
|
|
Thanks! @bors r+ |
|
📌 Commit c7312fb has been approved by |
bors
added
S-waiting-on-bors
|
🔒 Merge conflict |
bors
added
S-waiting-on-author
|
It looks like bors had a hiccup and marked a bunch of PRs with "merge conflict" even though no such conflict existed? I'm going to poke this again. @bors r+ |
|
💡 This pull request was already approved, no need to approve it again.
|
|
📌 Commit c7312fb has been approved by |
bors
added
S-waiting-on-bors
|
@bors retry (reasoning up-thread) |
GuillaumeGomez
added a commit
to GuillaumeGomez/rust
that referenced
this pull request
May 31, 2018
…r=QuietMisdreavus Fixes some style issues in rustdoc "implementations on Foreign types" Fixes rust-lang#51113. r? @QuietMisdreavus
bors
added a commit
that referenced
this pull request
May 31, 2018
Rollup of 7 pull requests Successful merges: - #49546 (Stabilize short error format) - #51123 (Update build instructions) - #51146 (typeck: Do not pass the field check on field error) - #51193 (Fixes some style issues in rustdoc "implementations on Foreign types") - #51213 (fs: copy: Use File::set_permissions instead of fs::set_permissions) - #51227 (mod.rs isn't beautiful) - #51240 (Two minor parsing tweaks) Failed merges:
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #51113.
r? @QuietMisdreavus