Skip to content

std: Child::kill() returns error if process has already exited #49461

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Apr 24, 2018
Merged

std: Child::kill() returns error if process has already exited #49461

Changes from 3 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
7eb9a09
std: Child::kill() returns error if process has already exited
andreastt Mar 28, 2018
d541282
fixup! std: Child::kill() returns error if process has already exited
andreastt Mar 28, 2018
51dc630
fixup! std: Child::kill() returns error if process has already exited
andreastt Mar 29, 2018
fd2afa0
fixup! std: Child::kill() returns error if process has already exited
andreastt Apr 8, 2018
bc4bd56
fixup! std: Child::kill() returns error if process has already exited
andreastt Apr 17, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 11 additions & 2 deletions src/libstd/process.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1121,8 +1121,13 @@ impl ExitCode {
}

impl Child {
/// Forces the child to exit. This is equivalent to sending a
/// SIGKILL on unix platforms.
/// Forces the child process to exit. If the child has already exited, an [`InvalidInput`]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: Double space after the period.

/// error is returned.
///
/// The mapping to [`ErrorKind`]s is not part of the compatibility contract of the function,
/// especially the [`Other`] kind might change to more specific kinds in the future.
///
/// This is equivalent to sending a SIGKILL on Unix platforms.
///
/// # Examples
///
Expand All @@ -1138,6 +1143,10 @@ impl Child {
/// println!("yes command didn't start");
/// }
/// ```
///
/// [`ErrorKind`]: ../io/enum.ErrorKind.html
/// [`InvalidInput`]: ../io/enum.ErrorKind.html#variant.InvalidInput
/// [`Other]: ../io/enum.ErrorKind.html#variant.Other
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing a '`' on Other

#[stable(feature = "process", since = "1.0.0")]
pub fn kill(&mut self) -> io::Result<()> {
self.handle.kill()
Expand Down