Turn feature-gate table into a query so it is covered by dependency tracking. #48208
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(rust_highfive has picked a reviewer for you, use r? to override) |
michaelwoerister
changed the title
pietroalbini
added
the
S-waiting-on-review
michaelwoerister
force-pushed
the
track-features
branch
2 times, most recently
from
23a0009 to
c0517a3
Compare
|
@bors r+ |
|
📌 Commit d691c46 has been approved by |
bors
added
S-waiting-on-bors
Manishearth
added a commit
to Manishearth/rust
that referenced
this pull request
Feb 19, 2018
…petrochenkov Turn feature-gate table into a query so it is covered by dependency tracking. Turn access to feature gates into a query so we handle them correctly during incremental compilation. Features are still available via `Session` through `features_untracked()`. I wish we had a better way of hiding untracked information. It would be great if we could remove the `sess` field from `TyCtxt`. Fixes rust-lang#47003.
Manishearth
added a commit
to Manishearth/rust
that referenced
this pull request
Feb 20, 2018
…petrochenkov Fixes rust-lang#47311. r? @nrc
bors
added a commit
that referenced
this pull request
Feb 20, 2018
Manishearth
added a commit
to Manishearth/rust
that referenced
this pull request
Feb 24, 2018
…petrochenkov Turn feature-gate table into a query so it is covered by dependency tracking. Turn access to feature gates into a query so we handle them correctly during incremental compilation. Features are still available via `Session` through `features_untracked()`. I wish we had a better way of hiding untracked information. It would be great if we could remove the `sess` field from `TyCtxt`. Fixes rust-lang#47003.
bors
added a commit
that referenced
this pull request
Feb 24, 2018
bors
added
S-waiting-on-bors
|
☔ The latest upstream changes (presumably #48586) made this pull request unmergeable. Please resolve the merge conflicts. |
bors
added
S-waiting-on-author
michaelwoerister
force-pushed
the
track-features
branch
from
4fd260d to
93625f1
Compare
|
Rebased. @bors r=petrochenkov |
|
📌 Commit 93625f1 has been approved by |
bors
added
S-waiting-on-bors
bors
added a commit
that referenced
this pull request
Mar 5, 2018
Turn feature-gate table into a query so it is covered by dependency tracking. Turn access to feature gates into a query so we handle them correctly during incremental compilation. Features are still available via `Session` through `features_untracked()`. I wish we had a better way of hiding untracked information. It would be great if we could remove the `sess` field from `TyCtxt`. Fixes #47003.
|
💔 Test failed - status-appveyor |
bors
added
S-waiting-on-review
This was referenced Mar 5, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Turn access to feature gates into a query so we handle them correctly during incremental compilation.
Features are still available via
Sessionthroughfeatures_untracked(). I wish we had a better way of hiding untracked information. It would be great if we could remove thesessfield fromTyCtxt.Fixes #47003.