Skip to content

Conversation

Mark-Simulacrum
Copy link
Member

I think this is all fine but I have little familiarity with the atomic code (or libcore in general) so I may have accidentally done something wrong here...

cc #13226 (the tracking issue)

r? @alexcrichton

@Mark-Simulacrum Mark-Simulacrum changed the title Add fetch_nand. Add fetch_nand to atomics Feb 9, 2018
@alexcrichton
Copy link
Member

@bors: r+

Thanks!

@bors
Copy link
Collaborator

bors commented Feb 9, 2018

📌 Commit 4ef0a4a has been approved by alexcrichton

@bors bors added the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label Feb 9, 2018
@kennytm
Copy link
Member

kennytm commented Feb 9, 2018

@bors r-

Missing #![feature].

[01:20:34]    Compiling std v0.0.0 (file:///checkout/src/libstd)
[01:20:34] error[E0658]: use of unstable library feature 'atomic_nand' (see issue #13226)
[01:20:34]   --> libcore/../libcore/tests/atomic.rs:54:18
[01:20:34]    |
[01:20:34] 54 |     assert_eq!(x.fetch_nand(0x137f, SeqCst), 0xf731);
[01:20:34]    |                  ^^^^^^^^^^
[01:20:34]    |
[01:20:34]    = help: add #![feature(atomic_nand)] to the crate attributes to enable
[01:20:34] 
[01:20:34] error[E0658]: use of unstable library feature 'atomic_nand' (see issue #13226)
[01:20:34]   --> libcore/../libcore/tests/atomic.rs:82:18
[01:20:34]    |
[01:20:34] 82 |     assert_eq!(x.fetch_nand(0x137f, SeqCst), 0xf731);
[01:20:34]    |                  ^^^^^^^^^^
[01:20:34]    |
[01:20:34]    = help: add #![feature(atomic_nand)] to the crate attributes to enable
[01:20:34] 
[01:20:53] error: aborting due to 2 previous errors
[01:20:53] 
[01:20:53] error: Could not compile `core`.

@bors bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Feb 9, 2018
@Mark-Simulacrum
Copy link
Member Author

Waiting on Travis because I suspect that I missed some feature annotations elsewhere as well.

cc rust-lang#13226 (the tracking issue)
@kennytm
Copy link
Member

kennytm commented Feb 10, 2018

@bors r=alexcrichton

@bors
Copy link
Collaborator

bors commented Feb 10, 2018

📌 Commit 1335b3d has been approved by alexcrichton

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Feb 10, 2018
kennytm added a commit to kennytm/rust that referenced this pull request Feb 10, 2018
…richton

Add fetch_nand to atomics

I think this is all fine but I have little familiarity with the atomic code (or libcore in general) so I may have accidentally done something wrong here...

cc rust-lang#13226 (the tracking issue)
bors added a commit that referenced this pull request Feb 10, 2018
Rollup of 16 pull requests

- Successful merges: #47790, #47835, #47854, #48015, #48047, #48051, #48058, #48059, #48064, #48078, #48080, #48086, #48098, #48101, #48107, #48100
- Failed merges:
bors added a commit that referenced this pull request Feb 10, 2018
@bors bors merged commit 1335b3d into rust-lang:master Feb 10, 2018
@Mark-Simulacrum Mark-Simulacrum deleted the fetch-nand branch June 8, 2019 13:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants