- 
                Notifications
    
You must be signed in to change notification settings  - Fork 13.9k
 
Add ./x.py check src/{libstd,libtest,librustc} #47460
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
| 
           cc @rust-lang/compiler  | 
    
206c1c4    to
    cc8717f      
    Compare
  
            
          
                src/bootstrap/flags.rs
              
                Outdated
          
        
      There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Checking in non-stage-0 may still be useful if we want to check libstd after some new semantic is implemented:
./x.py build --stage 0 src/librustc
./x.py check --keep-stage 1 --stage 1 src/libstd
# edit
./x.py check --keep-stage 1 --stage 1 src/libstd
# edit
./x.py check --keep-stage 1 --stage 1 src/libstd| 
           What exactly do these do?  | 
    
| 
           This runs   | 
    
| 
           OK, that's great!  | 
    
| 
           ☔ The latest upstream changes (presumably #47528) made this pull request unmergeable. Please resolve the merge conflicts.  | 
    
| 
           Oops sorry about that, looks great to me! r=me  | 
    
cc8717f    to
    7319232      
    Compare
  
    | 
           @bors r=alexcrichton  | 
    
| 
           📌 Commit 7319232 has been approved by   | 
    
| 
           Should this option be mentioned in https://github.com/rust-lang/rust/blob/master/CONTRIBUTING.md#the-build-system?  | 
    
| 
           Probably, yes. I'll open an issue.  | 
    
| 
           ☔ The latest upstream changes (presumably #47678) made this pull request unmergeable. Please resolve the merge conflicts.  | 
    
This currently only supports a limited subset of the full compilation, but is likely 90% of what people will want and is possible without building a full compiler (i.e., running LLVM). In theory, this means that contributors who don't want to build LLVM now have an easy way to compile locally, though running tests won't work.
7319232    to
    6aeb1cf      
    Compare
  
    | 
           @bors r=alexcrichton  | 
    
| 
           📌 Commit 6aeb1cf has been approved by   | 
    
…alexcrichton
Add ./x.py check src/{libstd,libtest,librustc}
This currently only supports a limited subset of the full compilation,
but is likely 90% of what people will want and is possible without
building a full compiler (and also building LLVM). In theory, this means
that contributors who don't want to build LLVM now have an easy way to
compile locally, though running tests won't work.
    
This currently only supports a limited subset of the full compilation,
but is likely 90% of what people will want and is possible without
building a full compiler (and also building LLVM). In theory, this means
that contributors who don't want to build LLVM now have an easy way to
compile locally, though running tests won't work.