Add a default directory for -Zdump-mir-dir #47426
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The current behaviour of dumping in the current directory is rarely desirable: a sensible default directory for dumping is much more convenient.
kennytm
added
the
S-waiting-on-review
kennytm
reviewed
Jan 14, 2018
src/librustc/session/config.rs
Outdated
| dump_mir: Option<String> = (None, parse_opt_string, [UNTRACKED], | ||
| "dump MIR state at various points in translation"), | ||
| dump_mir_dir: Option<String> = (None, parse_opt_string, [UNTRACKED], | ||
| dump_mir_dir: Option<String> = (Some(String::from("mir_dump")), parse_opt_string, [UNTRACKED], |
There was a problem hiding this comment.
Could this be a String instead of Option<String> then?
There was a problem hiding this comment.
That's a good point! It's now non-optional.
|
@bors r+ |
|
📌 Commit 394b95f has been approved by |
kennytm
added a commit
to kennytm/rust
that referenced
this pull request
Jan 17, 2018
…matsakis Add a default directory for -Zmir-dump-dir The current behaviour of dumping in the current directory is rarely desirable: a sensible default directory for dumping is much more convenient. This makes sets the default value for `-Zmir-dump-dir` to `mir_dump/`. r? @eddyb
kennytm
added a commit
to kennytm/rust
that referenced
this pull request
Jan 17, 2018
…matsakis Add a default directory for -Zmir-dump-dir The current behaviour of dumping in the current directory is rarely desirable: a sensible default directory for dumping is much more convenient. This makes sets the default value for `-Zmir-dump-dir` to `mir_dump/`. r? @eddyb
bors
added a commit
that referenced
this pull request
Jan 17, 2018
varkor
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current behaviour of dumping in the current directory is rarely
desirable: a sensible default directory for dumping is much more
convenient. This makes sets the default value for
-Zdump-mir-dirto
mir_dump/.r? @eddyb