Remove T: Ord bound from BTreeSet::{is_empty, len}
#47162
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @kennytm (rust_highfive has picked a reviewer for you, use r? to override) |
|
Please fix the merge conflict first... (cc @rust-lang/libs) |
kennytm
added
the
S-waiting-on-author
|
@bors: r+ Thanks! |
|
📌 Commit 6076cf6 has been approved by |
alexcrichton
added
S-waiting-on-bors
kennytm
added a commit
to kennytm/rust
that referenced
this pull request
Jan 5, 2018
…ichton
Remove `T: Ord` bound from `BTreeSet::{is_empty, len}`
This change makes the API for `BTreeSet` more consistent with `BTreeMap`, where `BTreeMap::{is_empty, len}` don't require `T: Ord` either.
Also, it reduces the number of `impl`s for `BTreeSet`, making the generated documentation look much cleaner. Closes rust-lang#47138.
cc @rust-lang/libs
ghost
deleted the
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change makes the API for
BTreeSetmore consistent withBTreeMap, whereBTreeMap::{is_empty, len}don't requireT: Ordeither.Also, it reduces the number of
impls forBTreeSet, making the generated documentation look much cleaner. Closes #47138.cc @rust-lang/libs