Skip to content

Conversation

mark-i-m
Copy link
Contributor

@mark-i-m mark-i-m commented Jan 1, 2018

I am assuming that there was once something else you could do and somebody forgot to remove "either". Is that correct?

@rust-highfive
Copy link
Contributor

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @eddyb (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@steveklabnik
Copy link
Contributor

@bors: r+ rollup

thanks!

@bors
Copy link
Collaborator

bors commented Jan 1, 2018

📌 Commit 05cbe6d has been approved by steveklabnik

frewsxcv added a commit to frewsxcv/rust that referenced this pull request Jan 2, 2018
Fix typo

I am assuming that there was once something else you could do and somebody forgot to remove "either". Is that correct?
bors added a commit that referenced this pull request Jan 2, 2018
Rollup of 4 pull requests

- Successful merges: #47107, #47117, #47118, #47121
- Failed merges:
kennytm added a commit to kennytm/rust that referenced this pull request Jan 3, 2018
Fix typo

I am assuming that there was once something else you could do and somebody forgot to remove "either". Is that correct?
bors added a commit that referenced this pull request Jan 3, 2018
Rollup of 9 pull requests

- Successful merges: #47104, #47107, #47113, #47117, #47118, #47121, #47125, #47134, #47145
- Failed merges:
@bors bors merged commit 05cbe6d into rust-lang:master Jan 3, 2018
@mark-i-m mark-i-m deleted the patch-1 branch January 15, 2018 23:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants