incr.comp.: Use an array instead of a hashmap for storing result hashes. #46842
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nikomatsakis
approved these changes
Dec 19, 2017
kennytm
added
the
S-waiting-on-author
michaelwoerister
force-pushed
the
fingerprint-vec
branch
from
fef84c3 to
e6e5589
Compare
|
Seems like I was compiling with debug assertions off locally. Should be fixed now. |
kennytm
added
S-waiting-on-review
|
@bors r+ |
|
📌 Commit b2f7239 has been approved by |
kennytm
added
S-waiting-on-bors
|
⌛ Testing commit b2f7239 with merge 705ef67686b821588d9c0094e406add58362671e... |
|
💔 Test failed - status-appveyor |
|
@bors retry |
bors
added a commit
that referenced
this pull request
Dec 22, 2017
incr.comp.: Use an array instead of a hashmap for storing result hashes. Doing so should result in some of the core tracking components being faster. r? @nikomatsakis
|
☀️ Test successful - status-appveyor, status-travis |
This was referenced Dec 23, 2017
32 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Doing so should result in some of the core tracking components being faster.
r? @nikomatsakis