Skip to content

Use def span for conflicting impls and recursive fn #46804

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 19, 2017
Merged

Use def span for conflicting impls and recursive fn #46804

merged 1 commit into from
Dec 19, 2017

Conversation

estebank
Copy link
Contributor

No description provided.

@rust-highfive
Copy link
Contributor

r? @petrochenkov

(rust_highfive has picked a reviewer for you, use r? to override)

@kennytm kennytm added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Dec 18, 2017
@arielb1
Copy link
Contributor

arielb1 commented Dec 18, 2017

@bors r+ rollup

@bors
Copy link
Collaborator

bors commented Dec 18, 2017

📌 Commit ea64ab7 has been approved by arielb1

@petrochenkov petrochenkov assigned arielb1 and unassigned petrochenkov Dec 18, 2017
@petrochenkov petrochenkov added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Dec 18, 2017
GuillaumeGomez added a commit to GuillaumeGomez/rust that referenced this pull request Dec 18, 2017
@GuillaumeGomez
Rollup merge of rust-lang#46804 - estebank:conflicting-impl-def-span,…
3a2becb 
… r=arielb1

Use def span for conflicting impls and recursive fn
@GuillaumeGomez GuillaumeGomez mentioned this pull request Dec 18, 2017
Merged
bors added a commit that referenced this pull request Dec 19, 2017
@bors
Auto merge of #46829 - GuillaumeGomez:rollup, r=GuillaumeGomez
c8b94c6 
Rollup of 11 pull requests

- Successful merges: #46700, #46786, #46790, #46800, #46801, #46802, #46804, #46805, #46812, #46824, #46825
- Failed merges:
@bors bors merged commit ea64ab7 into rust-lang:master Dec 19, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@arielb1 arielb1

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@estebank @rust-highfive @arielb1 @bors @kennytm @petrochenkov