ThinLTO: updates for LLVM 5 #46652
Merged
ThinLTO: updates for LLVM 5 #46652
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(rust_highfive has picked a reviewer for you, use r? to override) |
src/rustllvm/PassWrapper.cpp
Outdated
| if (GlobalValue::isLocalLinkage(GVS->linkage())) | ||
| continue; | ||
| auto GUID = GVS->getOriginalName(); | ||
| #if LLVM_VERSION_GE(5, 0) | ||
| if (IsLiveByGUID(Ret->Index, GUID)) |
There was a problem hiding this comment.
I think this is just GVS->flags().Live?
There was a problem hiding this comment.
I copied from the relevant commit. I have no idea what's the pitfall.
There was a problem hiding this comment.
Let's switch to GVS->flags().Live.
There was a problem hiding this comment.
Please see here.
There was a problem hiding this comment.
There's a few reasons we should not use this construction:
- The implementation of
IsLiveByGUIDgoes from a GUID back to theGlobalValueSummarywhich is already in scope here asGVS. - We don't need to take
WithGlobalValueDeadStrippinginto account, this is all happening long before anything else.
Let's switch to GVS->flags().Live
kennytm
added
the
S-waiting-on-author
ishitatsuyuki
force-pushed
the
thinlto-backport
branch
from
65b26ea to
dffa36c
Compare
|
@bors: r+ |
|
📌 Commit dffa36c has been approved by |
kennytm
added
S-waiting-on-bors
|
⌛ Testing commit dffa36c with merge fa0ee7b8773610ad8aee58d31f23265fd31af98d... |
|
💔 Test failed - status-travis |
|
@bors retry — http://crosstool-ng.org was down. |
|
@bors rollup |
steveklabnik
added a commit
to steveklabnik/rust
that referenced
this pull request
Dec 15, 2017
…lexcrichton ThinLTO: updates for LLVM 5 refs: llvm-mirror/llvm@ccb80b9 llvm-mirror/llvm@e611018
bors
added a commit
that referenced
this pull request
Dec 15, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
refs:
llvm-mirror/llvm@ccb80b9
llvm-mirror/llvm@e611018