Add a mir pass to simplify temporaries that are immediately moved out of #46440
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The HIR->MIR build likes introducing these when you use local variables, and they can be cheaply and safely simplified.
|
r? @eddyb (rust_highfive has picked a reviewer for you, use r? to override) |
|
Initial reaction is I'm not sure we want this (as opposed to debuginfo-awareness in more general value/destination propagation). |
|
Closing after IRC discussion, as eddyb's figured out how to make full NRVO sound. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The HIR->MIR build likes introducing these when you use local variables, and they can be cheaply and safely simplified. The pass only runs when the two lines in the peephole have the same span and the local is a non-user variable, so it can be run even with full debug info requested.