Skip to content

Conversation

gnzlbg
Copy link
Contributor

@gnzlbg gnzlbg commented Nov 6, 2017

No description provided.

@rust-highfive
Copy link
Contributor

r? @arielb1

(rust_highfive has picked a reviewer for you, use r? to override)

@oli-obk
Copy link
Contributor

oli-obk commented Nov 6, 2017

You fixed a test :P

[00:50:04] ---- [compile-fail] compile-fail/simd-intrinsic-generic-arithmetic.rs stdout ----
[00:50:04] 	
[00:50:04] error: /checkout/src/test/compile-fail/simd-intrinsic-generic-arithmetic.rs:87: expected error not found: unsupported operation on `i32x4` with element `i32`
[00:50:04] 
[00:50:04] error: /checkout/src/test/compile-fail/simd-intrinsic-generic-arithmetic.rs:89: expected error not found: unsupported operation on `u32x4` with element `u32`
[00:50:04] 
[00:50:04] error: 0 unexpected errors found, 2 expected errors not found
[00:50:04] status: exit code: 101
[00:50:04] command: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/bin/rustc" "/checkout/src/test/compile-fail/simd-intrinsic-generic-arithmetic.rs" "-L" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/compile-fail" "--target=x86_64-unknown-linux-gnu" "--error-format" "json" "-C" "prefer-dynamic" "-o" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/compile-fail/simd-intrinsic-generic-arithmetic.stage2-x86_64-unknown-linux-gnu" "-Crpath" "-O" "-Lnative=/checkout/obj/build/x86_64-unknown-linux-gnu/native/rust-test-helpers" "-L" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/compile-fail/simd-intrinsic-generic-arithmetic.stage2-x86_64-unknown-linux-gnu.aux" "-A" "unused"
[00:50:04] not found errors (from test file): [
[00:50:04]     Error {
[00:50:04]         line_num: 87,
[00:50:04]         kind: Some(
[00:50:04]             Error
[00:50:04]         ),
[00:50:04]         msg: "unsupported operation on `i32x4` with element `i32`"
[00:50:04]     },
[00:50:04]     Error {
[00:50:04]         line_num: 89,
[00:50:04]         kind: Some(
[00:50:04]             Error
[00:50:04]         ),
[00:50:04]         msg: "unsupported operation on `u32x4` with element `u32`"
[00:50:04]     }
[00:50:04] ]
[00:50:04] 
[00:50:04] thread '[compile-fail] compile-fail/simd-intrinsic-generic-arithmetic.rs' panicked at 'explicit panic', /checkout/src/tools/compiletest/src/runtest.rs:1085:12
[00:50:04] 
[00:50:04] 
[00:50:04] failures:
[00:50:04]     [compile-fail] compile-fail/simd-intrinsic-generic-arithmetic.rs

@kennytm kennytm added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Nov 6, 2017
@gnzlbg
Copy link
Contributor Author

gnzlbg commented Nov 6, 2017

@oli-obk sorry about that 🤣

I've updated the tests.

@gnzlbg
Copy link
Contributor Author

gnzlbg commented Nov 6, 2017

r? @alexcrichton

@rust-highfive rust-highfive assigned alexcrichton and unassigned arielb1 Nov 6, 2017
@alexcrichton
Copy link
Member

@bors: r+

@bors
Copy link
Collaborator

bors commented Nov 6, 2017

📌 Commit 01ced6e has been approved by alexcrichton

@kennytm kennytm added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 7, 2017
kennytm added a commit to kennytm/rust that referenced this pull request Nov 7, 2017
[intrinsics] add missing div and rem vector intrinsics
@bors
Copy link
Collaborator

bors commented Nov 10, 2017

⌛ Testing commit 01ced6e with merge 75d25ac...

bors added a commit that referenced this pull request Nov 10, 2017
[intrinsics] add missing div and rem vector intrinsics
@bors
Copy link
Collaborator

bors commented Nov 10, 2017

☀️ Test successful - status-appveyor, status-travis
Approved by: alexcrichton
Pushing 75d25ac to master...

@bors bors merged commit 01ced6e into rust-lang:master Nov 10, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants