extend NLL with preliminary support for free regions on functions #45668
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Oct 31, 2017
nikomatsakis
force-pushed
the
nll-free-region
branch
from
9ca6dbe to
2288312
Compare
kennytm
added
the
S-waiting-on-author
This way, NLL can report them later.
Notably, the (hitherto unused) `less_than` method was not at all what it purported to be. It in fact computes the opposite.
nikomatsakis
force-pushed
the
nll-free-region
branch
from
7bbf680 to
67c0eab
Compare
nikomatsakis
changed the title
kennytm
added
S-waiting-on-review
This lets us inspect the regions we infer around named arguments.
Actually, I meant to make this use `delay_span_bug`
nikomatsakis
force-pushed
the
nll-free-region
branch
from
67c0eab to
7b4282e
Compare
|
review ping @arielb1, pinging you on IRC too! |
|
@bors r+ |
|
📌 Commit 7b4282e has been approved by |
|
@bors p=1 Giving this higher priority because it's a building block for other PRs in/around non-lexical lifetimes, and because NLL in general is a very high priority item. |
bors
added a commit
that referenced
this pull request
Nov 6, 2017
extend NLL with preliminary support for free regions on functions This PR extends #45538 with support for free regions. This is pretty preliminary and will no doubt want to change in various ways, particularly as we add support for closures, but it's enough to get the basic idea in place: - We now create specific regions to represent each named lifetime declared on the function. - Region values can contain references to these regions (represented for now as a `BTreeSet<RegionIndex>`). - If we wind up trying to infer that `'a: 'b` must hold, but no such relationship was declared, we report an error. It also does a number of drive-by refactorings. r? @arielb1 cc @spastorino
kennytm
added
S-waiting-on-bors
|
☀️ Test successful - status-appveyor, status-travis |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR extends #45538 with support for free regions. This is pretty preliminary and will no doubt want to change in various ways, particularly as we add support for closures, but it's enough to get the basic idea in place:
BTreeSet<RegionIndex>).'a: 'bmust hold, but no such relationship was declared, we report an error.It also does a number of drive-by refactorings.
r? @arielb1
cc @spastorino