rustbuild: Don't build with ThinLTO on MIPS #45655
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Discovered in rust-lang#45529 it looks like cross-module TLS imports aren't quite working today, especially with `hidden` visibility which mostly comes up with multiple codegen units. As a result this completely disables compiling with ThinLTO and multiple codegen units on MIPS when bootstrapping. cc rust-lang#45654, the tracking issue for this
|
(rust_highfive has picked a reviewer for you, use r? to override) |
This was referenced Oct 31, 2017
|
@bors r+ |
|
📌 Commit b1fd5a7 has been approved by |
|
@bors p=3 Three other PRs depend on this. |
kennytm
added
the
S-waiting-on-bors
bors
added a commit
that referenced
this pull request
Oct 31, 2017
rustbuild: Don't build with ThinLTO on MIPS Discovered in #45529 it looks like cross-module TLS imports aren't quite working today, especially with `hidden` visibility which mostly comes up with multiple codegen units. As a result this completely disables compiling with ThinLTO and multiple codegen units on MIPS when bootstrapping. cc #45654, the tracking issue for this
|
☀️ Test successful - status-appveyor, status-travis |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Discovered in #45529 it looks like cross-module TLS imports aren't quite working
today, especially with
hiddenvisibility which mostly comes up with multiplecodegen units. As a result this completely disables compiling with ThinLTO and
multiple codegen units on MIPS when bootstrapping.
cc #45654, the tracking issue for this