rustbuild: Fix no output generated error for next bootstrap cargo.
#45496
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Due to rust-lang/cargo#4570, a `*.dll.lib` file is uplifted when building dynamic libraries on Windows. The current bootstrap code does not understand files with multiple extensions, and will instead assume `xxxx.dll` is the file name. This caused a `no output generated` error because it tries to search for `xxxx.dll-hash.lib` inside the `deps/` folder, while it should check for `xxxx-hash.dll.lib` instead. This PR is blocking rust-lang#45285 (Bump to 1.23 and update bootstrap).
|
(rust_highfive has picked a reviewer for you, use r? to override) |
kennytm
added
the
S-waiting-on-review
|
Seems fine to me but I'm not really experienced with Cargo's output enough to r+ this. |
|
@bors: r+ Thanks! |
|
📌 Commit 3b81573 has been approved by |
|
⌛ Testing commit 3b81573 with merge 86754211c7323b188efb71e7e156968cc2383f4d... |
|
💔 Test failed - status-appveyor |
|
@bors retry 3 hour timed out. |
kennytm
added
S-waiting-on-bors
kennytm
added a commit
to kennytm/rust
that referenced
this pull request
Oct 25, 2017
…ck, r=alexcrichton rustbuild: Fix `no output generated` error for next bootstrap cargo. Due to rust-lang/cargo#4570, a `*.dll.lib` file is uplifted when building dynamic libraries on Windows. The current bootstrap code does not understand files with multiple extensions, and will instead assume `xxxx.dll` is the file name. This caused a `no output generated` error because it tries to search for `xxxx.dll-hash.lib` inside the `deps/` folder, while it should check for `xxxx-hash.dll.lib` instead. This PR is blocking rust-lang#45285, see rust-lang#45285 (comment) and the rest of the comments for detail.
bors
added a commit
that referenced
this pull request
Oct 25, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Due to rust-lang/cargo#4570, a
*.dll.libfile is uplifted when building dynamic libraries on Windows. The current bootstrap code does not understand files with multiple extensions, and will instead assumexxxx.dllis the file name. This caused ano output generatederror because it tries to search forxxxx.dll-hash.libinside thedeps/folder, while it should check forxxxx-hash.dll.libinstead.This PR is blocking #45285, see #45285 (comment) and the rest of the comments for detail.