Skip to content

Mobile sidebar improvements #45240

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 13, 2017
Merged

Mobile sidebar improvements #45240

merged 1 commit into from
Oct 13, 2017

Conversation

GuillaumeGomez
Copy link
Member

Very small changes, I just made the width of the sidebar of 100% and centered vertically both items a bit more:

screen shot 2017-10-12 at 20 00 47

r? @rust-lang/docs

@GuillaumeGomez GuillaumeGomez force-pushed the mobile-sidebar-improvements branch from 8797a7b to 9da9c3b Compare October 12, 2017 18:02
@kennytm kennytm added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Oct 12, 2017
@QuietMisdreavus
Copy link
Contributor

Could you also show a "before" screenshot?

@GuillaumeGomez
Copy link
Member Author

Here:

screen shot 2017-10-13 at 15 36 08

@QuietMisdreavus
Copy link
Contributor

Thanks! Looks like a subtle change, but i like how the sidebar color spans the whole width now.

@bors r+ rollup

@bors
Copy link
Collaborator

bors commented Oct 13, 2017

📌 Commit 9da9c3b has been approved by QuietMisdreavus

kennytm added a commit to kennytm/rust that referenced this pull request Oct 13, 2017
@kennytm
Rollup merge of rust-lang#45240 - GuillaumeGomez:mobile-sidebar-impro…
f43c54e 
…vements, r=QuietMisdreavus

Mobile sidebar improvements

Very small changes, I just made the width of the sidebar of 100% and centered vertically both items a bit more:

<img width="1440" alt="screen shot 2017-10-12 at 20 00 47" src="https://user-images.githubusercontent.com/3050060/31511496-302bb474-af88-11e7-8dab-2c88799eafcc.png">

r? @rust-lang/docs
@kennytm kennytm mentioned this pull request Oct 13, 2017
Merged
bors added a commit that referenced this pull request Oct 13, 2017
@bors
Auto merge of #45261 - kennytm:rollup, r=kennytm
6cb49d2 
Rollup of 14 pull requests

- Successful merges: #44855, #45110, #45122, #45133, #45173, #45178, #45189, #45203, #45209, #45221, #45236, #45240, #45245, #45253
- Failed merges:
@bors bors merged commit 9da9c3b into rust-lang:master Oct 13, 2017
@GuillaumeGomez GuillaumeGomez deleted the mobile-sidebar-improvements branch October 14, 2017 13:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@GuillaumeGomez @QuietMisdreavus @bors @kennytm